linux-kernel - Re: [PATCH v5 03/28] media: iris: implement iris v4l2 file ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11191c49-3a05-e97c-0d17-592074f5acff@quicinc.com>
Date: Wed, 13 Nov 2024 10:45:01 +0530
From: Dikshita Agarwal <quic_dikshita@...cinc.com>
To: Bryan O'Donoghue <pure.logic@...us-software.ie>,
        Vikash Garodia
	<quic_vgarodia@...cinc.com>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
CC: Hans Verkuil <hverkuil@...all.nl>,
        Sebastian Fricke
	<sebastian.fricke@...labora.com>,
        Bryan O'Donoghue
	<bryan.odonoghue@...aro.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Nicolas Dufresne
	<nicolas@...fresne.ca>,
        Uwe Kleine-König
	<u.kleine-koenig@...libre.com>,
        Jianhua Lu <lujianhua000@...il.com>, <linux-media@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 03/28] media: iris: implement iris v4l2 file ops



On 11/10/2024 8:40 AM, Bryan O'Donoghue wrote:
> On 05/11/2024 06:55, Dikshita Agarwal wrote:
>> Implement open, close and poll ops.
>>
>> Open:
>> Configure the vb2 queue and v4l2 file handler. Allocate a video instance
>> and add the instance to core instance list.
>>
>> Close:
>> Free the instance and remove it from core instance list.
> 
> Its a bit odd that you describe the purpose of open and close but not poll,
> despite listing poll along with open and close at the very top.
> 
> Consider adding that text if you do a next version.
> 
We didn't describe the poll since we are making use of m2m API for that.
but sure can describe that as well.

Thanks,
Dikshita
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> 
> ---
> bod