linux-kernel - Re: Re: [PATCH liburing] test: add test cases for hybrid iopoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241113062511.3079688-1-xue01.he@samsung.com>
Date: Wed, 13 Nov 2024 14:25:11 +0800
From: hexue <xue01.he@...sung.com>
To: asml.silence@...il.com
Cc: axboe@...nel.dk, io-uring@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH liburing] test: add test cases for hybrid iopoll

On 11/13/24 3:32, Pavel Begunkov wrote:
>On 11/11/24 12:36, hexue wrote:
>> Add a test file for hybrid iopoll to make sure it works safe.Testcass
>> include basic read/write tests, and run in normal iopoll mode and
>> passthrough mode respectively.
>>
>> Signed-off-by: hexue <xue01.he@...sung.com>

>If it's not covered already please add tests for failure cases.
>E.g. when SETUP_HYBRID_IOPOLL is set without SETUP_IOPOLL

I'll thinking about this part.

>> +	ring_flags |= IORING_SETUP_SQE128;
>> +	ring_flags |= IORING_SETUP_CQE32;
>> +	ring_flags |= IORING_SETUP_HYBRID_IOPOLL;
>> +
>> +	if (sqthread)
>> +		ring_flags |= IORING_SETUP_SQPOLL;

>Doesn't it also need IORING_SETUP_IOPOLL?

You're right, will fix this.

--
hexue