linux-kernel - Re: Re: [PATCH liburing] test: add test cases for hybrid iopoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241113062652.3080848-1-xue01.he@samsung.com>
Date: Wed, 13 Nov 2024 14:26:52 +0800
From: hexue <xue01.he@...sung.com>
To: anuj20.g@...sung.com
Cc: asml.silence@...il.com, axboe@...nel.dk, io-uring@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH liburing] test: add test cases for hybrid iopoll

On 11/12/24 3:44 AM, Anuj Gupta wrote:
>> +utilization than polling. Similarly, this feature also requires the devices
>> +to support polling configuration.
> This feature would work if a device doesn't have polled queues,right?
> The performance might be suboptimal in that case, but the userspace won't
> get any errors.

The usersapce will get error in this case. Hybrid must be dependent on iopoll,
if hybrid polling is set separately,it will not pass detection and an error will
be returned. Therefore, device end cnnfigured are required for polling.

......

> This patch mostly looks fine. But the code here seems to be largely
> duplicated from "test/io_uring_passthrough.c" and "test/iopoll.c".
> Can we consider adding the hybrid poll test as a part of the existing
> tests as it seems that it would only require passing a extra flag
> during ring setup.

Make sense, I will try to do this in exsiting test file. Thank you very much.

--
hexue