linux-kernel - RE: [PATCH net] samples: pktgen: correct dev to DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8510E9AF9E925D93C851E8A8885A2@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Wed, 13 Nov 2024 10:06:28 +0000
From: Wei Fang <wei.fang@....com>
To: Jesper Dangaard Brouer <hawk@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"horms@...nel.org" <horms@...nel.org>, "lorenzo@...nel.org"
	<lorenzo@...nel.org>
Subject: RE: [PATCH net] samples: pktgen: correct dev to DEV

> On 12/11/2024 04.03, Wei Fang wrote:
> > In the pktgen_sample01_simple.sh script, the device variable is
> > uppercase 'DEV' instead of lowercase 'dev'. Because of this typo, the
> > script cannot enable UDP tx checksum.
> >
> > Fixes: 460a9aa23de6 ("samples: pktgen: add UDP tx checksum support")
> > Signed-off-by: Wei Fang <wei.fang@....com>
> > ---
> >   samples/pktgen/pktgen_sample01_simple.sh | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/samples/pktgen/pktgen_sample01_simple.sh
> > b/samples/pktgen/pktgen_sample01_simple.sh
> > index cdb9f497f87d..66cb707479e6 100755
> > --- a/samples/pktgen/pktgen_sample01_simple.sh
> > +++ b/samples/pktgen/pktgen_sample01_simple.sh
> 
> Why are you only fixing one script?
> 

Other scripts are correct, because they are all multi-threaded, "dev" is
defined for each thread like below.

dev=${DEV}@...hread}


> The fixes commit 460a9aa23de6 changes many files, introducing this bug.
> 
> > @@ -76,7 +76,7 @@ if [ -n "$DST_PORT" ]; then
> >       pg_set $DEV "udp_dst_max $UDP_DST_MAX"
> >   fi
> >
> > -[ ! -z "$UDP_CSUM" ] && pg_set $dev "flag UDPCSUM"
> > +[ ! -z "$UDP_CSUM" ] && pg_set $DEV "flag UDPCSUM"
> >
> 
> This fix looks correct, but we also need to fix other scripts
> 
> >   # Setup random UDP port src range
> >   pg_set $DEV "flag UDPSRC_RND"
> 
> 
> $ git whatchanged -1 460a9aa23de6 | grep 'M     samples'| awk -FM
> '{print $2}'
> 	samples/pktgen/parameters.sh
> 	samples/pktgen/pktgen_sample01_simple.sh
> 	samples/pktgen/pktgen_sample02_multiqueue.sh
> 	samples/pktgen/pktgen_sample03_burst_single_flow.sh
> 	samples/pktgen/pktgen_sample04_many_flows.sh
> 	samples/pktgen/pktgen_sample05_flow_per_thread.sh
> 	samples/pktgen/pktgen_sample06_numa_awared_queue_irq_affinity.sh
> 
> Thanks for spotting this, but please also fix the other scripts :-)
> 
> --Jesper