linux-kernel - Re: [PATCH net] samples: pktgen: correct dev to DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e54aa43-8299-4166-8724-ebe48a9a9747@kernel.org>
Date: Wed, 13 Nov 2024 13:19:18 +0100
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Wei Fang <wei.fang@....com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "horms@...nel.org" <horms@...nel.org>,
 "lorenzo@...nel.org" <lorenzo@...nel.org>
Subject: Re: [PATCH net] samples: pktgen: correct dev to DEV



On 13/11/2024 11.06, Wei Fang wrote:
>> On 12/11/2024 04.03, Wei Fang wrote:
>>> In the pktgen_sample01_simple.sh script, the device variable is
>>> uppercase 'DEV' instead of lowercase 'dev'. Because of this typo, the
>>> script cannot enable UDP tx checksum.
>>>
>>> Fixes: 460a9aa23de6 ("samples: pktgen: add UDP tx checksum support")
>>> Signed-off-by: Wei Fang <wei.fang@....com>
>>> ---
>>>    samples/pktgen/pktgen_sample01_simple.sh | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/samples/pktgen/pktgen_sample01_simple.sh
>>> b/samples/pktgen/pktgen_sample01_simple.sh
>>> index cdb9f497f87d..66cb707479e6 100755
>>> --- a/samples/pktgen/pktgen_sample01_simple.sh
>>> +++ b/samples/pktgen/pktgen_sample01_simple.sh
>>
>> Why are you only fixing one script?
>>
> 
> Other scripts are correct, because they are all multi-threaded, "dev" is
> defined for each thread like below.
> 
> dev=${DEV}@...hread}
> 

Good point! - then this patch is enough :-)

Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>

Thanks for fixing this,
--Jesper