linux-kernel - Re: [PATCH v2 2/2] drm/amd/pm: remove redundant tools

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_OmxZ=tHrByQkDiFdwydpvunpkGWTsb8sLq9zb9ajXdkQ@mail.gmail.com>
Date: Thu, 14 Nov 2024 16:18:40 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Bhavin Sharma <bhavin.sharma@...iconsignals.io>
Cc: alexander.deucher@....com, alex.hung@....com, 
	Harry Wentland <harry.wentland@....com>, Leo Li <sunpeng.li@....com>, 
	Rodrigo Siqueira <Rodrigo.Siqueira@....com>, Christian König <christian.koenig@....com>, 
	Xinhui Pan <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Kenneth Feng <kenneth.feng@....com>, Wenjing Liu <wenjing.liu@....com>, Leo Ma <hanghong.ma@....com>, 
	Ryan Seto <ryanseto@....com>, Jose Fernandez <josef@...flix.com>, 
	Ilya Bakoulin <ilya.bakoulin@....com>, Aurabindo Pillai <aurabindo.pillai@....com>, 
	amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] drm/amd/pm: remove redundant tools_size check

Applied.  Thanks!

On Thu, Nov 14, 2024 at 10:12 AM Bhavin Sharma
<bhavin.sharma@...iconsignals.io> wrote:
>
> The check for tools_size being non-zero is redundant as tools_size is
> explicitly set to a non-zero value (0x19000). Removing the if condition
> simplifies the code without altering functionality.
>
> Signed-off-by: Bhavin Sharma <bhavin.sharma@...iconsignals.io>
> ---
>  .../amd/pm/powerplay/smumgr/vega12_smumgr.c   | 24 +++++++++----------
>  1 file changed, 11 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/vega12_smumgr.c b/drivers/gpu/drm/amd/pm/powerplay/smumgr/vega12_smumgr.c
> index b52ce135d84d..d3ff6a831ed5 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/vega12_smumgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/vega12_smumgr.c
> @@ -257,20 +257,18 @@ static int vega12_smu_init(struct pp_hwmgr *hwmgr)
>         priv->smu_tables.entry[TABLE_WATERMARKS].size = sizeof(Watermarks_t);
>
>         tools_size = 0x19000;
> -       if (tools_size) {
> -               ret = amdgpu_bo_create_kernel((struct amdgpu_device *)hwmgr->adev,
> -                                             tools_size,
> -                                             PAGE_SIZE,
> -                                             AMDGPU_GEM_DOMAIN_VRAM,
> -                                             &priv->smu_tables.entry[TABLE_PMSTATUSLOG].handle,
> -                                             &priv->smu_tables.entry[TABLE_PMSTATUSLOG].mc_addr,
> -                                             &priv->smu_tables.entry[TABLE_PMSTATUSLOG].table);
> -               if (ret)
> -                       goto err1;
> +       ret = amdgpu_bo_create_kernel((struct amdgpu_device *)hwmgr->adev,
> +                                     tools_size,
> +                                     PAGE_SIZE,
> +                                     AMDGPU_GEM_DOMAIN_VRAM,
> +                                     &priv->smu_tables.entry[TABLE_PMSTATUSLOG].handle,
> +                                     &priv->smu_tables.entry[TABLE_PMSTATUSLOG].mc_addr,
> +                                     &priv->smu_tables.entry[TABLE_PMSTATUSLOG].table);
> +       if (ret)
> +               goto err1;
>
> -               priv->smu_tables.entry[TABLE_PMSTATUSLOG].version = 0x01;
> -               priv->smu_tables.entry[TABLE_PMSTATUSLOG].size = tools_size;
> -       }
> +       priv->smu_tables.entry[TABLE_PMSTATUSLOG].version = 0x01;
> +       priv->smu_tables.entry[TABLE_PMSTATUSLOG].size = tools_size;
>
>         /* allocate space for AVFS Fuse table */
>         ret = amdgpu_bo_create_kernel((struct amdgpu_device *)hwmgr->adev,
> --
> 2.43.0
>