linux-kernel - Re: [PATCH v2 1/2] drm/amd/display: remove redundant is_dsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_MXiOYYLKii4UiziDoKhefiPFy28++NxY5Ss_jp9ob9BA@mail.gmail.com>
Date: Thu, 14 Nov 2024 16:20:59 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Christian König <christian.koenig@....com>
Cc: Bhavin Sharma <bhavin.sharma@...iconsignals.io>, alexander.deucher@....com, 
	alex.hung@....com, Harry Wentland <harry.wentland@....com>, Leo Li <sunpeng.li@....com>, 
	Rodrigo Siqueira <Rodrigo.Siqueira@....com>, Xinhui Pan <Xinhui.Pan@....com>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Kenneth Feng <kenneth.feng@....com>, 
	Wenjing Liu <wenjing.liu@....com>, Chris Park <chris.park@....com>, Roman Li <roman.li@....com>, 
	Leo Ma <hanghong.ma@....com>, Ryan Seto <ryanseto@....com>, 
	Jose Fernandez <josef@...flix.com>, Ilya Bakoulin <ilya.bakoulin@....com>, 
	Aurabindo Pillai <aurabindo.pillai@....com>, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] drm/amd/display: remove redundant is_dsc_possible check

On Thu, Nov 14, 2024 at 10:21 AM Christian König
<christian.koenig@....com> wrote:
>
> Am 14.11.24 um 16:11 schrieb Bhavin Sharma:
> > Since is_dsc_possible is already checked just above, there's no need to
> > check it again before filling out the DSC settings.
> >
> > Signed-off-by: Bhavin Sharma <bhavin.sharma@...iconsignals.io>
> > ---
> >   drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 13 +++++--------
> >   1 file changed, 5 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> > index ebd5df1a36e8..85f6f8e43947 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c
> > @@ -1093,14 +1093,11 @@ static bool setup_dsc_config(
> >       if (!is_dsc_possible)
> >               goto done;
> >
> > -     // Final decission: can we do DSC or not?
> > -     if (is_dsc_possible) {
> > -             // Fill out the rest of DSC settings
> > -             dsc_cfg->block_pred_enable = dsc_common_caps.is_block_pred_supported;
> > -             dsc_cfg->linebuf_depth = dsc_common_caps.lb_bit_depth;
> > -             dsc_cfg->version_minor = (dsc_common_caps.dsc_version & 0xf0) >> 4;
> > -             dsc_cfg->is_dp = dsc_sink_caps->is_dp;
> > -     }
> > +     // Fill out the rest of DSC settings
>
> While at it you should probably replace the // style comment with /* */.
>
> Apart from that looks good to me.

Fixed up locally and applied.

Thanks,

Alex

>
> Christian.
>
> > +     dsc_cfg->block_pred_enable = dsc_common_caps.is_block_pred_supported;
> > +     dsc_cfg->linebuf_depth = dsc_common_caps.lb_bit_depth;
> > +     dsc_cfg->version_minor = (dsc_common_caps.dsc_version & 0xf0) >> 4;
> > +     dsc_cfg->is_dp = dsc_sink_caps->is_dp;
> >
> >   done:
> >       if (!is_dsc_possible)
>