linux-kernel - Re: [PATCH v2 04/35] x86/bugs: Restructure mds mitigation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241114030343.ewjeiyisjycjlxpo@desk>
Date: Wed, 13 Nov 2024 19:03:43 -0800
From: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
To: David Kaplan <david.kaplan@....com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Borislav Petkov <bp@...en8.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Josh Poimboeuf <jpoimboe@...nel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H . Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 04/35] x86/bugs: Restructure mds mitigation

On Tue, Nov 05, 2024 at 03:54:24PM -0600, David Kaplan wrote:
> @@ -277,12 +304,19 @@ enum rfds_mitigations {
>  static enum rfds_mitigations rfds_mitigation __ro_after_init =
>  	IS_ENABLED(CONFIG_MITIGATION_RFDS) ? RFDS_MITIGATION_AUTO : RFDS_MITIGATION_OFF;
>  
> +/* Return TRUE if any VERW-based mitigation is enabled. */
> +static bool __init mitigate_any_verw(void)

s/mitigate_any_verw/verw_enabled/ ?

> +{
> +	return (mds_mitigation != MDS_MITIGATION_OFF ||
> +		taa_mitigation != TAA_MITIGATION_OFF ||

TAA_MITIGATION_TSX_DISABLED does not require VERW, this should be:

		taa_mitigation != TAA_MITIGATION_OFF ||
		taa_mitigation != TAA_MITIGATION_TSX_DISABLED ||

> +		mmio_mitigation != MMIO_MITIGATION_OFF ||
> +		rfds_mitigation != RFDS_MITIGATION_OFF);
> +}