linux-kernel - Re: [PATCH v2 05/35] x86/bugs: Restructure taa mitigation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241114044317.22i2vlekf7zimt4d@desk>
Date: Wed, 13 Nov 2024 20:43:17 -0800
From: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
To: David Kaplan <david.kaplan@....com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Borislav Petkov <bp@...en8.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Josh Poimboeuf <jpoimboe@...nel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H . Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 05/35] x86/bugs: Restructure taa mitigation

On Tue, Nov 05, 2024 at 03:54:25PM -0600, David Kaplan wrote:
> +static void __init taa_update_mitigation(void)
> +{
> +	if (!boot_cpu_has_bug(X86_BUG_TAA))
> +		return;
> +
> +	if (mitigate_any_verw())
> +		taa_mitigation = TAA_MITIGATION_VERW;

This isn't right, TAA_MITIGATION_UCODE_NEEDED can never get set
irrespective of microcode.

The UCODE_NEEDED checks in taa_select_mitigation() actually belongs here.