linux-kernel - Re: [PATCH v5 05/28] media: iris: implement video firmware load/unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e88f7d3-7823-d550-f0d1-5f50cfee79ac@quicinc.com>
Date: Thu, 14 Nov 2024 11:17:34 +0530
From: Dikshita Agarwal <quic_dikshita@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Vikash Garodia
	<quic_vgarodia@...cinc.com>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
CC: Hans Verkuil <hverkuil@...all.nl>,
        Sebastian Fricke
	<sebastian.fricke@...labora.com>,
        Dmitry Baryshkov
	<dmitry.baryshkov@...aro.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Nicolas Dufresne <nicolas@...fresne.ca>,
        Uwe Kleine-König
	<u.kleine-koenig@...libre.com>,
        Jianhua Lu <lujianhua000@...il.com>, <linux-media@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 05/28] media: iris: implement video firmware
 load/unload



On 11/13/2024 9:26 PM, Bryan O'Donoghue wrote:
> On 13/11/2024 05:20, Dikshita Agarwal wrote:
>>>> +err_put_node:
>>>> +    of_node_put(node);
>>> remove
>> Sure, Will make the change.
>> but are we just trying to avoid using "goto" here?
>>
>> Thanks,
>> Dikshita
> 
> Currently you'd be leaking because you only do the put on the error path.
> 
>> +    rmem = of_reserved_mem_lookup(node);
> 
> of_node_put(node);
> 
Ah, Right!
Will fix this

Thanks,
Dikshita
> ---
> bod