linux-kernel - Re: [PATCH 1/2] kbuild: do not pass -r to genksyms when *.symref does not exist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241114-nondescript-overjoyed-cricket-52ccdb@lindesnes>
Date: Thu, 14 Nov 2024 11:56:34 +0100
From: Nicolas Schier <nicolas@...sle.eu>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, Nathan Chancellor <nathan@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] kbuild: do not pass -r to genksyms when *.symref
 does not exist

On Tue, Nov 12, 2024 at 02:17:40AM +0900, Masahiro Yamada wrote:
> There is no need to pass '-r /dev/null', which is no-op.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  scripts/Makefile.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 8f423a1faf50..36eae845a3e3 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -110,7 +110,7 @@ $(obj)/%.i: $(obj)/%.c FORCE
>  genksyms = scripts/genksyms/genksyms		\
>  	$(if $(1), -T $(2))			\
>  	$(if $(KBUILD_PRESERVE), -p)		\
> -	-r $(or $(wildcard $(2:.symtypes=.symref)), /dev/null)
> +	$(addprefix -r , $(wildcard $(2:.symtypes=.symref)))
>  
>  # These mirror gensymtypes_S and co below, keep them in synch.
>  cmd_gensymtypes_c = $(CPP) -D__GENKSYMS__ $(c_flags) $< | $(genksyms)
> -- 
> 2.43.0
> 

Reviewed-by: Nicolas Schier <nicolas@...sle.eu>