linux-kernel - Re: [PATCH 2/2] kbuild: remove support for single %.symtypes build rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241114-mouflon-of-nonconcrete-jest-badbe0@lindesnes>
Date: Thu, 14 Nov 2024 11:57:11 +0100
From: Nicolas Schier <nicolas@...sle.eu>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, Nathan Chancellor <nathan@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] kbuild: remove support for single %.symtypes build
 rule

On Tue, Nov 12, 2024 at 02:17:41AM +0900, Masahiro Yamada wrote:
> This rule is unnecessary because you can generate foo/bar.symtypes
> as a side effect using:
> 
>   $ make KBUILD_SYMTYPES=1 foo/bar.o
> 
> While compiling *.o is slower than preprocessing, the impact is
> negligible. I prioritize keeping the code simpler.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  Makefile               |  2 +-
>  scripts/Makefile.build | 20 +++-----------------
>  2 files changed, 4 insertions(+), 18 deletions(-)

thanks, looks good to me.

Reviewed-by: Nicolas Schier <nicolas@...sle.eu>