linux-kernel - Re: [PATCH] gpio: gpio-exar: replace division condition with direct comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9daa71f-cba7-4086-a523-a2e6aa526ff3@stanley.mountain>
Date: Fri, 15 Nov 2024 14:55:12 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Suraj Sonawane <surajsonawane0215@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: gpio-exar: replace division condition with direct
 comparison

Uh, I had to think back...  I had forgotten that I actually published that
check.  I can unpublish it.

I wrote it based on a real issue, and then when I looked at the warnings quite
a few places wrote code like "if (x / 4)" where they had intended to write if
if ((x % 4) == 0).  So it seemed like a good idea.

But in the two years since I published the warning, it has mostly been false
positives.

regards,
dan carpenter