linux-kernel - Re: [PATCH] gpio: gpio-exar: replace division condition with direct comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MfuC8rfag-8vxFqJ=qsXzsTpoBfvP+xWS9+rBdj0H0epQ@mail.gmail.com>
Date: Fri, 15 Nov 2024 12:58:48 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	Suraj Sonawane <surajsonawane0215@...il.com>, Linus Walleij <linus.walleij@...aro.org>, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: gpio-exar: replace division condition with direct comparison

On Fri, Nov 15, 2024 at 12:55 PM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> Uh, I had to think back...  I had forgotten that I actually published that
> check.  I can unpublish it.
>
> I wrote it based on a real issue, and then when I looked at the warnings quite
> a few places wrote code like "if (x / 4)" where they had intended to write if
> if ((x % 4) == 0).  So it seemed like a good idea.
>
> But in the two years since I published the warning, it has mostly been false
> positives.
>
> regards,
> dan carpenter
>

Ok, I dropped this patch from my queue. I typically trust smatch so I
picked it up without giving it much thought.

Bart