linux-kernel - Re: [PATCH 2/3] x86/ioremap: use helper to implement xxx_is_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzhZinP5QLwHrPYa@gmail.com>
Date: Sat, 16 Nov 2024 09:36:26 +0100
From: Ingo Molnar <mingo@...nel.org>
To: Tom Lendacky <thomas.lendacky@....com>
Cc: Baoquan He <bhe@...hat.com>, linux-kernel@...r.kernel.org, bp@...en8.de,
	x86@...nel.org
Subject: Re: [PATCH 2/3] x86/ioremap: use helper to implement
 xxx_is_setup_data()


* Tom Lendacky <thomas.lendacky@....com> wrote:

> On 11/14/24 19:21, Baoquan He wrote:
> > This simplifies codes a lot by removing the duplicated code handling.
> 
> You should probably squash this with the first patch.
> 
> > 
> > And also remove the similar code comment above of them.
> > 
> > While at it, add __ref to memremap_is_setup_data() to avoid
> 
> The __ref shouldn't be needed if you remove the __init from the helper
> function.

Yeah.

Baoquan, I've zapped these 3 commits from tip:x86/mm for now, mind resending them the init 
annotations fixed?

Thanks,

	Ingo