linux-kernel - Re: [PATCH 2/3] x86/ioremap: use helper to implement xxx_is_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zzid8dMZHAmfyUI9@MiWiFi-R3L-srv>
Date: Sat, 16 Nov 2024 21:28:17 +0800
From: Baoquan He <bhe@...hat.com>
To: Ingo Molnar <mingo@...nel.org>
Cc: Tom Lendacky <thomas.lendacky@....com>, linux-kernel@...r.kernel.org,
	bp@...en8.de, x86@...nel.org
Subject: Re: [PATCH 2/3] x86/ioremap: use helper to implement
 xxx_is_setup_data()

On 11/16/24 at 09:36am, Ingo Molnar wrote:
> 
> * Tom Lendacky <thomas.lendacky@....com> wrote:
> 
> > On 11/14/24 19:21, Baoquan He wrote:
> > > This simplifies codes a lot by removing the duplicated code handling.
> > 
> > You should probably squash this with the first patch.
> > 
> > > 
> > > And also remove the similar code comment above of them.
> > > 
> > > While at it, add __ref to memremap_is_setup_data() to avoid
> > 
> > The __ref shouldn't be needed if you remove the __init from the helper
> > function.
> 
> Yeah.
> 
> Baoquan, I've zapped these 3 commits from tip:x86/mm for now, mind resending them the init 
> annotations fixed?

Sure, will resend. Thanks.