linux-kernel - [PATCH v2 2/2] f2fs: clear SBI_POR_DOING before initing inmem curseg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241118120517.3533055-2-shengyong@oppo.com>
Date: Mon, 18 Nov 2024 20:05:17 +0800
From: Sheng Yong <shengyong@...o.com>
To: jaegeuk@...nel.org,
	chao@...nel.org
Cc: linux-f2fs-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org,
	Sheng Yong <shengyong@...o.com>,
	Song Feng <songfeng@...o.com>,
	Yongpeng Yang <yangyongpeng1@...o.com>
Subject: [PATCH v2 2/2] f2fs: clear SBI_POR_DOING before initing inmem curseg

SBI_POR_DOING can be cleared after recovery is completed, so that
changes made before recovery can be persistent, and subsequent
errors can be recorded into cp/sb.

Signed-off-by: Song Feng <songfeng@...o.com>
Signed-off-by: Yongpeng Yang <yangyongpeng1@...o.com>
Signed-off-by: Sheng Yong <shengyong@...o.com>
Reviewed-by: Chao Yu <chao@...nel.org>
---
 fs/f2fs/super.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 072462896716..1d22e5ee7331 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -4748,13 +4748,13 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
 	if (err)
 		goto free_meta;
 
+	/* f2fs_recover_fsync_data() cleared this already */
+	clear_sbi_flag(sbi, SBI_POR_DOING);
+
 	err = f2fs_init_inmem_curseg(sbi);
 	if (err)
 		goto sync_free_meta;
 
-	/* f2fs_recover_fsync_data() cleared this already */
-	clear_sbi_flag(sbi, SBI_POR_DOING);
-
 	if (test_opt(sbi, DISABLE_CHECKPOINT)) {
 		err = f2fs_disable_checkpoint(sbi);
 		if (err)
-- 
2.40.1