linux-kernel - Re: [PATCH v2 1/2] f2fs: fix changing cursegs if recovery fails on zoned device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bdc3c8eb-2c26-4575-af7c-f54541beca5a@kernel.org>
Date: Tue, 19 Nov 2024 09:11:22 +0800
From: Chao Yu <chao@...nel.org>
To: Sheng Yong <shengyong@...o.com>, jaegeuk@...nel.org
Cc: Chao Yu <chao@...nel.org>, linux-f2fs-devel@...ts.sourceforge.net,
 linux-kernel@...r.kernel.org, Song Feng <songfeng@...o.com>,
 Yongpeng Yang <yangyongpeng1@...o.com>
Subject: Re: [PATCH v2 1/2] f2fs: fix changing cursegs if recovery fails on
 zoned device

On 2024/11/18 20:05, Sheng Yong wrote:
> Fsync data recovery attempts to check and fix write pointer consistency
> of cursegs and all other zones. If the write pointers of cursegs are
> unaligned, cursegs are changed to new sections.
> 
> If recovery fails, zone write pointers are still checked and fixed,
> but the latest checkpoint cannot be written back. Additionally, retry-
> mount skips recovery and rolls back to reuse the old cursegs whose
> zones are already finished. This can lead to unaligned write later.
> 
> This patch addresses the issue by leaving writer pointers untouched if
> recovery fails. When retry-mount is performed, cursegs and other zones
> are checked and fixed after skipping recovery.
> 
> Signed-off-by: Song Feng <songfeng@...o.com>
> Signed-off-by: Yongpeng Yang <yangyongpeng1@...o.com>
> Signed-off-by: Sheng Yong <shengyong@...o.com>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,