linux-kernel - Re: [PATCH v4 17/19] fpga: dfl: remove unneeded function build_info_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZztV/d8PPk2f33wk@yilunxu-OptiPlex-7050>
Date: Mon, 18 Nov 2024 22:58:05 +0800
From: Xu Yilun <yilun.xu@...ux.intel.com>
To: Peter Colberg <peter.colberg@...el.com>
Cc: Wu Hao <hao.wu@...el.com>, Tom Rix <trix@...hat.com>,
	Moritz Fischer <mdf@...nel.org>, Xu Yilun <yilun.xu@...el.com>,
	linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
	Russ Weight <russ.weight@...ux.dev>,
	Marco Pagani <marpagan@...hat.com>,
	Matthew Gerlach <matthew.gerlach@...ux.intel.com>,
	Basheer Ahmed Muddebihal <basheer.ahmed.muddebihal@...ux.intel.com>
Subject: Re: [PATCH v4 17/19] fpga: dfl: remove unneeded function
 build_info_create_dev()

On Fri, Oct 25, 2024 at 06:37:12PM -0400, Peter Colberg wrote:
> Now that the platform device allocation has been moved from
> build_info_create_dev() to feature_dev_register(), the former
> no longer serves its original purpose and may be removed.

may be removed? It is removed in this patch, please be confirmative.

Thanks,
Yilun

> 
> Signed-off-by: Peter Colberg <peter.colberg@...el.com>
> Reviewed-by: Matthew Gerlach <matthew.gerlach@...ux.intel.com>
> Reviewed-by: Basheer Ahmed Muddebihal <basheer.ahmed.muddebihal@...ux.intel.com>
> ---
> Changes since v3:
> - New patch extracted from last patch of v3 series.
> ---
>  drivers/fpga/dfl.c | 17 ++---------------
>  1 file changed, 2 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c
> index d9cef150ed0d..a2459b0cbc68 100644
> --- a/drivers/fpga/dfl.c
> +++ b/drivers/fpga/dfl.c
> @@ -858,16 +858,6 @@ binfo_create_feature_dev_data(struct build_feature_devs_info *binfo)
>  	return fdata;
>  }
>  
> -static int
> -build_info_create_dev(struct build_feature_devs_info *binfo)
> -{
> -	binfo->feature_num = 0;
> -
> -	INIT_LIST_HEAD(&binfo->sub_features);
> -
> -	return 0;
> -}
> -
>  /*
>   * register current feature device, it is called when we need to switch to
>   * another feature parsing or we have parsed all features on given device
> @@ -1316,11 +1306,8 @@ static int parse_feature_fiu(struct build_feature_devs_info *binfo,
>  		return -EINVAL;
>  
>  	binfo->type = type;
> -
> -	/* create platform device for dfl feature dev */
> -	ret = build_info_create_dev(binfo);
> -	if (ret)
> -		return ret;
> +	binfo->feature_num = 0;
> +	INIT_LIST_HEAD(&binfo->sub_features);
>  
>  	ret = create_feature_instance(binfo, 0, 0, 0);
>  	if (ret)
> -- 
> 2.47.0
> 
>