[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <02537f27-ac3b-4e2e-80a2-ad57230ac478@paulmck-laptop>
Date: Mon, 18 Nov 2024 07:05:05 -0800
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Jonas Oberhauser <jonas.oberhauser@...weicloud.com>
Cc: Akira Yokosawa <akiyks@...il.com>, boqun.feng@...il.com,
dhowells@...hat.com, dlustig@...dia.com, frederic@...nel.org,
hernan.poncedeleon@...weicloud.com, j.alglave@....ac.uk,
joel@...lfernandes.org, linux-kernel@...r.kernel.org,
lkmm@...ts.linux.dev, luc.maranget@...ia.fr, npiggin@...il.com,
parri.andrea@...il.com, peterz@...radead.org,
quic_neeraju@...cinc.com, stern@...land.harvard.edu,
urezki@...il.com, will@...nel.org
Subject: Re: [PATCH v4 5/5] tools/memory-model: Distinguish between syntactic
and semantic tags
On Fri, Nov 08, 2024 at 10:35:24AM -0800, Paul E. McKenney wrote:
> On Fri, Nov 08, 2024 at 12:07:43PM +0100, Jonas Oberhauser wrote:
> >
> >
> > Am 11/8/2024 um 11:12 AM schrieb Akira Yokosawa:
> > > On Fri, 8 Nov 2024 10:10:48 +0100, Jonas Oberhauser wrote:
> > > > I hadn't done that before (because I thought I should not add other people's tags
> > > > especially if they hadn't reviewed that specific revision), so we may be missing
> > > > *a lot* of reviewed-by...
> > > >
> > >
> > > Section "Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes:"
> > > of Documentation/process/submitting-patches.rst has this paragraph:
> > >
> > > Both Tested-by and Reviewed-by tags, once received on mailing list from tester
> > > or reviewer, should be added by author to the applicable patches when sending
> > > next versions. However if the patch has changed substantially in following
> > > version, these tags might not be applicable anymore and thus should be removed.
> > > Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned
> > > in the patch changelog (after the '---' separator).
> > >
> > > Does this help you?
> >
> > Thanks so much, it does. My apologies to everyone whose reviewed-by tag I
> > failed to add :(
> >
> > I should have read that more document more carefully.
>
> No worries! The important part is your changes. The tags are easy
> to add. And now you know. ;-)
The first three of your patches could go in, but the last two require a
new herd7 release (for the lkmmv2 flag). Left to myself, I would hold
all five until we get a new herd7 release, but if it is important to
get the first three into the current merge window, please rebase them
to mainline some time this week. I would then send a pull request for
the for next week, the second and final week of the merge window.
Over to you!
Thanx, Paul
Powered by blists - more mailing lists