linux-kernel - Re: [PATCH v4 19/19] fpga: dfl: destroy/recreate feature platform device on port release/assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZztYlcidn3zU2vn5@yilunxu-OptiPlex-7050>
Date: Mon, 18 Nov 2024 23:09:09 +0800
From: Xu Yilun <yilun.xu@...ux.intel.com>
To: Peter Colberg <peter.colberg@...el.com>
Cc: Wu Hao <hao.wu@...el.com>, Tom Rix <trix@...hat.com>,
	Moritz Fischer <mdf@...nel.org>, Xu Yilun <yilun.xu@...el.com>,
	linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
	Russ Weight <russ.weight@...ux.dev>,
	Marco Pagani <marpagan@...hat.com>,
	Matthew Gerlach <matthew.gerlach@...ux.intel.com>,
	Basheer Ahmed Muddebihal <basheer.ahmed.muddebihal@...ux.intel.com>,
	Russ Weight <russell.h.weight@...el.com>
Subject: Re: [PATCH v4 19/19] fpga: dfl: destroy/recreate feature platform
 device on port release/assign

On Fri, Oct 25, 2024 at 06:37:14PM -0400, Peter Colberg wrote:
> From: Xu Yilun <yilun.xu@...el.com>
> 
> Now that the internal DFL APIs have been converted to consume DFL
> enumeration info from a separate structure, dfl_feature_dev_data, which
> lifetime is independent of the feature device, proceed to completely
> destroy and recreate the feature platform device on port release and
> assign, respectively. This resolves a longstanding issue in the use of
> platform_device_add(), which states to "not call this routine more than
> once for any device structure" and which used to print a kernel warning.
> 
> The function feature_dev_unregister() resets the device pointer in the
> feature data to NULL to signal that the feature platform device has been
> destroyed. This substitutes the previous device_is_registered() checks.

Acked-by: Xu Yilun <yilun.xu@...el.com>

for this patch and all other patches that I didn't comment in this
series.

Thanks.

> 
> Signed-off-by: Xu Yilun <yilun.xu@...el.com>
> Signed-off-by: Russ Weight <russell.h.weight@...el.com>
> Signed-off-by: Peter Colberg <peter.colberg@...el.com>
> Reviewed-by: Matthew Gerlach <matthew.gerlach@...ux.intel.com>
> Reviewed-by: Basheer Ahmed Muddebihal <basheer.ahmed.muddebihal@...ux.intel.com>