linux-kernel - Re: [PATCH] mm: Remove 'return;' at the end of void cma_activate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241119191344.53712-1-sj@kernel.org>
Date: Tue, 19 Nov 2024 11:13:44 -0800
From: SeongJae Park <sj@...nel.org>
To: winterver <295107659@...com>
Cc: SeongJae Park <sj@...nel.org>,
	akpm@...ux-foundation.org,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Pintu Kumar <quic_pintu@...cinc.com>
Subject: Re: [PATCH] mm: Remove 'return;' at the end of void cma_activate_area()

Hello,

On Tue, 19 Nov 2024 19:59:40 +0800 winterver <295107659@...com> wrote:

> From: Jiale Yang <295107659@...com>
> 
> Remove 'return;' at the end of void cma_activate_area(). It's a void
> function, so an ending return statement is unnecessary.
> 
> Signed-off-by: Jiale Yang <295107659@...com>
> ---
>  mm/cma.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/cma.c b/mm/cma.c
> index 2d9fae939..070399bce 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -135,7 +135,6 @@ static void __init cma_activate_area(struct cma *cma)
>  	totalcma_pages -= cma->count;
>  	cma->count = 0;
>  	pr_err("CMA area %s could not be activated\n", cma->name);
> -	return;
>  }

Looks good to me.  But, seems a same change[1] from Pintu Kumar has already
merged into mm-unstable?

[1] https://lore.kernel.org/20240927181637.19941-1-quic_pintu@quicinc.com


Thanks,
SJ

>  
>  static int __init cma_init_reserved_areas(void)
> -- 
> 2.43.0