linux-kernel - Re: [PATCH] mm: Remove 'return;' at the end of void cma_activate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a83683b-9e7e-4583-bc47-2a008b9d3c87@redhat.com>
Date: Tue, 19 Nov 2024 13:59:25 +0100
From: David Hildenbrand <david@...hat.com>
To: winterver <295107659@...com>, akpm@...ux-foundation.org
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: Remove 'return;' at the end of void
 cma_activate_area()

On 19.11.24 12:59, winterver wrote:
> From: Jiale Yang <295107659@...com>
> 
> Remove 'return;' at the end of void cma_activate_area(). It's a void
> function, so an ending return statement is unnecessary.
> 
> Signed-off-by: Jiale Yang <295107659@...com>
> ---
>   mm/cma.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/mm/cma.c b/mm/cma.c
> index 2d9fae939..070399bce 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -135,7 +135,6 @@ static void __init cma_activate_area(struct cma *cma)
>   	totalcma_pages -= cma->count;
>   	cma->count = 0;
>   	pr_err("CMA area %s could not be activated\n", cma->name);
> -	return;
>   }
>   
>   static int __init cma_init_reserved_areas(void)

Reviewed-by: David Hildenbrand <david@...hat.com>


-- 
Cheers,

David / dhildenb