linux-kernel - Re: [PATCH v2] Bluetooth: qca: Support downloading board ID specific NVM for WCN6855

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zzw56VwjTmlJ7mpW@hovoldconsulting.com>
Date: Tue, 19 Nov 2024 08:10:33 +0100
From: Johan Hovold <johan@...nel.org>
To: quic_zijuhu <quic_zijuhu@...cinc.com>
Cc: Marcel Holtmann <marcel@...tmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@...il.com>,
	Bjorn Andersson <andersson@...nel.org>,
	Steev Klimaszewski <steev@...i.org>,
	Paul Menzel <pmenzel@...gen.mpg.de>, Zijun Hu <zijun_hu@...oud.com>,
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
	Luiz Augusto von Dentz <luiz.von.dentz@...el.com>,
	Bjorn Andersson <bjorande@...cinc.com>,
	"Aiqun Yu (Maria)" <quic_aiquny@...cinc.com>,
	Cheng Jiang <quic_chejiang@...cinc.com>,
	Jens Glathe <jens.glathe@...schoolsolutions.biz>,
	stable@...r.kernel.org, Johan Hovold <johan+linaro@...nel.org>
Subject: Re: [PATCH v2] Bluetooth: qca: Support downloading board ID specific
 NVM for WCN6855

On Tue, Nov 19, 2024 at 10:13:11AM +0800, quic_zijuhu wrote:
> On 11/18/2024 8:43 PM, Johan Hovold wrote:
> > On Sat, Nov 16, 2024 at 07:49:23AM -0800, Zijun Hu wrote:
> >> For WCN6855, board ID specific NVM needs to be downloaded once board ID
> >> is available, but the default NVM is always downloaded currently, and
> >> the wrong NVM causes poor RF performance which effects user experience.
> >>
> >> Fix by downloading board ID specific NVM if board ID is available.

> >> Fixes: 095327fede00 ("Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855")
> >> Cc: stable@...r.kernel.org # 6.4
> >> Reviewed-by: Johan Hovold <johan+linaro@...nel.org>
> > 
> > When making non-trivial changes, like the addition of the fallback NVM
> > feature in v2, you should probably have dropped any previous Reviewed-by
> > tags.
> 
> make sense. will notice these aspects for further patches.
> 
> > The fallback handling looks good to me though (and also works as
> > expected).
> 
> so, is it okay to make this patch still keep tags given by you ?

Yes, it's fine to keep my Reviewed-by and Tested-by tags.

> >> Tested-by: Johan Hovold <johan+linaro@...nel.org>
> >> Tested-by: Steev Klimaszewski <steev@...i.org>
> >> Tested-by: Jens Glathe <jens.glathe@...schoolsolutions.biz>
> >> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> > 
> >> Changes in v2:
> >> - Correct subject and commit message
> >> - Temporarily add nvm fallback logic to speed up backport.
> >> — Add fix/stable tags as suggested by Luiz and Johan
> >> - Link to v1: https://lore.kernel.org/r/20241113-x13s_wcn6855_fix-v1-1-15af0aa2549c@quicinc.com

> > If you think it's ok for people to continue using the wrong (default)
> > NVM file for a while still until their distros ship the board-specific
> > ones, then this looks good to me and should ease the transition:
> 
> yes. i think it is okay now.

Then I think this patch is ready to be merged.

Thanks again for your help with this.

Johan