linux-kernel - Re: [PATCH v2] Bluetooth: qca: Support downloading board ID specific NVM for WCN6855

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8360f26a-f384-4089-b50a-ae9751f503db@quicinc.com>
Date: Wed, 4 Dec 2024 12:50:27 +0800
From: quic_zijuhu <quic_zijuhu@...cinc.com>
To: Luiz Augusto von Dentz <luiz.dentz@...il.com>
CC: Paul Menzel <pmenzel@...gen.mpg.de>, Zijun Hu <zijun_hu@...oud.com>,
        <linux-bluetooth@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "Luiz
 Augusto von Dentz" <luiz.von.dentz@...el.com>,
        Bjorn Andersson
	<bjorande@...cinc.com>,
        "Aiqun Yu (Maria)" <quic_aiquny@...cinc.com>,
        "Cheng
 Jiang" <quic_chejiang@...cinc.com>,
        Johan Hovold <johan@...nel.org>,
        "Jens
 Glathe" <jens.glathe@...schoolsolutions.biz>,
        <stable@...r.kernel.org>, "Johan Hovold" <johan+linaro@...nel.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Steev Klimaszewski <steev@...i.org>,
        Marcel Holtmann
	<marcel@...tmann.org>
Subject: Re: [PATCH v2] Bluetooth: qca: Support downloading board ID specific
 NVM for WCN6855

On 11/16/2024 11:49 PM, Zijun Hu wrote:
> For WCN6855, board ID specific NVM needs to be downloaded once board ID
> is available, but the default NVM is always downloaded currently, and
> the wrong NVM causes poor RF performance which effects user experience.
> 

Hi Luiz,

could you please code review for this change ?

several types of product in market need this fix, hope it will go to
mainline as early as possible.

sorry for this noise.

> Fix by downloading board ID specific NVM if board ID is available.
> 
> Cc: Bjorn Andersson <bjorande@...cinc.com>
> Cc: Aiqun Yu (Maria) <quic_aiquny@...cinc.com>
> Cc: Cheng Jiang <quic_chejiang@...cinc.com>
> Cc: Johan Hovold <johan@...nel.org>
> Cc: Jens Glathe <jens.glathe@...schoolsolutions.biz>
> Cc: Steev Klimaszewski <steev@...i.org>
> Cc: Paul Menzel <pmenzel@...gen.mpg.de>
> Fixes: 095327fede00 ("Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855")
> Cc: stable@...r.kernel.org # 6.4
> Reviewed-by: Johan Hovold <johan+linaro@...nel.org>
> Tested-by: Johan Hovold <johan+linaro@...nel.org>
> Tested-by: Steev Klimaszewski <steev@...i.org>
> Tested-by: Jens Glathe <jens.glathe@...schoolsolutions.biz>
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> ---
> Thank you Paul, Jens, Steev, Johan, Luiz for code review, various
> verification, comments and suggestions. these comments and suggestions
> are very good, and all of them are taken by this v2 patch.
> 
> Regarding the variant 'g', sorry for that i can say nothing due to
> confidential information (CCI), but fortunately, we don't need to
> care about its difference against one without 'g' from BT host
> perspective, qca_get_hsp_nvm_name_generic() shows how to map BT chip
> to firmware.
> 
> I will help to backport it to LTS kernels ASAP once this commit
> is mainlined.
> ---
> Changes in v2:
> - Correct subject and commit message
> - Temporarily add nvm fallback logic to speed up backport.
> — Add fix/stable tags as suggested by Luiz and Johan
> - Link to v1: https://lore.kernel.org/r/20241113-x13s_wcn6855_fix-
> v1-1-15af0aa2549c@...cinc.com
> ---