linux-kernel - Re: [PATCH v2] Bluetooth: qca: Support downloading board ID specific NVM for WCN6855

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z1v8vLWH7TmwwzQl@hovoldconsulting.com>
Date: Fri, 13 Dec 2024 10:22:04 +0100
From: Johan Hovold <johan@...nel.org>
To: Zijun Hu <quic_zijuhu@...cinc.com>,
	Luiz Augusto von Dentz <luiz.dentz@...il.com>
Cc: Marcel Holtmann <marcel@...tmann.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Steev Klimaszewski <steev@...i.org>,
	Paul Menzel <pmenzel@...gen.mpg.de>, Zijun Hu <zijun_hu@...oud.com>,
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
	Luiz Augusto von Dentz <luiz.von.dentz@...el.com>,
	Bjorn Andersson <bjorande@...cinc.com>,
	"Aiqun Yu (Maria)" <quic_aiquny@...cinc.com>,
	Cheng Jiang <quic_chejiang@...cinc.com>,
	Jens Glathe <jens.glathe@...schoolsolutions.biz>,
	stable@...r.kernel.org, Johan Hovold <johan+linaro@...nel.org>
Subject: Re: [PATCH v2] Bluetooth: qca: Support downloading board ID specific
 NVM for WCN6855

Hi Luiz,

On Sat, Nov 16, 2024 at 07:49:23AM -0800, Zijun Hu wrote:
> For WCN6855, board ID specific NVM needs to be downloaded once board ID
> is available, but the default NVM is always downloaded currently, and
> the wrong NVM causes poor RF performance which effects user experience.
> 
> Fix by downloading board ID specific NVM if board ID is available.
> 
> Cc: Bjorn Andersson <bjorande@...cinc.com>
> Cc: Aiqun Yu (Maria) <quic_aiquny@...cinc.com>
> Cc: Cheng Jiang <quic_chejiang@...cinc.com>
> Cc: Johan Hovold <johan@...nel.org>
> Cc: Jens Glathe <jens.glathe@...schoolsolutions.biz>
> Cc: Steev Klimaszewski <steev@...i.org>
> Cc: Paul Menzel <pmenzel@...gen.mpg.de>
> Fixes: 095327fede00 ("Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855")
> Cc: stable@...r.kernel.org # 6.4
> Reviewed-by: Johan Hovold <johan+linaro@...nel.org>
> Tested-by: Johan Hovold <johan+linaro@...nel.org>
> Tested-by: Steev Klimaszewski <steev@...i.org>
> Tested-by: Jens Glathe <jens.glathe@...schoolsolutions.biz>
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>

> I will help to backport it to LTS kernels ASAP once this commit
> is mainlined.
> ---
> Changes in v2:
> - Correct subject and commit message
> - Temporarily add nvm fallback logic to speed up backport.
> — Add fix/stable tags as suggested by Luiz and Johan
> - Link to v1: https://lore.kernel.org/r/20241113-x13s_wcn6855_fix-v1-1-15af0aa2549c@quicinc.com

The board-specific NVM configuration files have now been included in the
linux-firmware-20241210 release and are making their way into the
distros (e.g. Arch Linux ARM and Fedora now ship them).

Could we get this merged for 6.13-rc (and backported) so that Lenovo
ThinkPad X13s users can finally enjoy excellent Bluetooth range? :)

Johan