lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z4TbyIfVJL85oVXs@hovoldconsulting.com>
Date: Mon, 13 Jan 2025 10:24:24 +0100
From: Johan Hovold <johan@...nel.org>
To: Zijun Hu <quic_zijuhu@...cinc.com>,
	Luiz Augusto von Dentz <luiz.dentz@...il.com>
Cc: Marcel Holtmann <marcel@...tmann.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Steev Klimaszewski <steev@...i.org>,
	Paul Menzel <pmenzel@...gen.mpg.de>, Zijun Hu <zijun_hu@...oud.com>,
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
	Luiz Augusto von Dentz <luiz.von.dentz@...el.com>,
	Bjorn Andersson <bjorande@...cinc.com>,
	"Aiqun Yu (Maria)" <quic_aiquny@...cinc.com>,
	Cheng Jiang <quic_chejiang@...cinc.com>,
	Jens Glathe <jens.glathe@...schoolsolutions.biz>,
	stable@...r.kernel.org, Johan Hovold <johan+linaro@...nel.org>
Subject: Re: [PATCH v2] Bluetooth: qca: Support downloading board ID specific
 NVM for WCN6855

Hi Luiz,

On Fri, Dec 13, 2024 at 10:22:05AM +0100, Johan Hovold wrote:
> On Sat, Nov 16, 2024 at 07:49:23AM -0800, Zijun Hu wrote:
> > For WCN6855, board ID specific NVM needs to be downloaded once board ID
> > is available, but the default NVM is always downloaded currently, and
> > the wrong NVM causes poor RF performance which effects user experience.
> > 
> > Fix by downloading board ID specific NVM if board ID is available.

> > Fixes: 095327fede00 ("Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855")
> > Cc: stable@...r.kernel.org # 6.4
> > Reviewed-by: Johan Hovold <johan+linaro@...nel.org>
> > Tested-by: Johan Hovold <johan+linaro@...nel.org>
> > Tested-by: Steev Klimaszewski <steev@...i.org>
> > Tested-by: Jens Glathe <jens.glathe@...schoolsolutions.biz>
> > Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> 
> > I will help to backport it to LTS kernels ASAP once this commit
> > is mainlined.
> > ---
> > Changes in v2:
> > - Correct subject and commit message
> > - Temporarily add nvm fallback logic to speed up backport.
> > — Add fix/stable tags as suggested by Luiz and Johan
> > - Link to v1: https://lore.kernel.org/r/20241113-x13s_wcn6855_fix-v1-1-15af0aa2549c@quicinc.com
> 
> The board-specific NVM configuration files have now been included in the
> linux-firmware-20241210 release and are making their way into the
> distros (e.g. Arch Linux ARM and Fedora now ship them).
> 
> Could we get this merged for 6.13-rc (and backported) so that Lenovo
> ThinkPad X13s users can finally enjoy excellent Bluetooth range? :)

This fix is still pending in your queue (I hope) and I was hoping you
would be able to get it into 6.13-rc. The reason, apart from this being
a crucial fix for users of this chipset, was also to avoid any conflicts
with the new "rampatch" firmware name feature (which will also
complicate backporting somewhat).

Those patches were resent on January 7 and have now been merged for 6.14
(presumably):

	https://lore.kernel.org/all/20250107092650.498154-1-quic_chejiang@quicinc.com/

How do we handle this? Can you still get this fix into 6.13 or is it
now, as I assume, too late for that?

Zijun, depending on Luiz' reply, can you look into rebasing on top of the
patches now queued for linux-next?

Johan

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ