linux-kernel - Re: [PATCH v2] pinctrl: renesas: rzg2l: Update PFC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdUGbxJGCZB8U2CJ5cj6QBx2GqXt-Pp6czWNaq=45bOw8w@mail.gmail.com>
Date: Mon, 13 Jan 2025 10:24:10 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Prabhakar <prabhakar.csengg@...il.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, linux-renesas-soc@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2] pinctrl: renesas: rzg2l: Update PFC_MASK to align with
 RZ/V2H requirements

On Fri, Jan 10, 2025 at 11:10 PM Prabhakar <prabhakar.csengg@...il.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> The PFC_MASK value for the PFC_mx register was previously hardcoded as
> `0x07`, which is correct for SoCs in the RZ/G2L family but insufficient
> for RZ/V2H and RZ/G3E, where the mask value should be `0x0f`. This
> discrepancy caused incorrect PFC register configurations on RZ/V2H and
> RZ/G3E SoCs.
>
> On the RZ/G2L, the PFC_mx bitfields are also 4 bits wide, with bit 4
> marked as reserved. The reserved bits are documented to read as zero and
> be ignored when written. Updating the PFC_MASK definition from `0x07` to
> `0x0f` ensures compatibility with both SoC families while maintaining
> correct behavior on RZ/G2L.
>
> Fixes: 9bd95ac86e70 ("pinctrl: renesas: rzg2l: Add support for RZ/V2H SoC")
> Cc: stable@...r.kernel.org
> Reported-by: Hien Huynh <hien.huynh.px@...esas.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> ---
> v1->v2
> - Dropped SoC specific configuration

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
i.e. will queue in renesas-pinctrl for v6.14, as it is a fix.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds