linux-kernel - Re: [PATCH net-next v2] net: wwan: Add WWAN sahara port type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <863ba24c-eca4-46e2-96ab-f7f995e75ad0@gmail.com>
Date: Wed, 20 Nov 2024 22:36:58 +0200
From: Sergey Ryazanov <ryazanov.s.a@...il.com>
To: Jerry Meng <jerry.meng.lk@...ctel.com>, loic.poulain@...aro.org,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: wwan: Add WWAN sahara port type

+Manivannan

Hello Jerry,

this version looks a way better, still there is one minor thing to 
improve. See below.

Manivannan, Loic, could you advice is it Ok to export that SAHARA port 
as is?

On 20.11.2024 11:39, Jerry Meng wrote:
> Add a Sahara protocol-based interface for downloading ramdump
> from Qualcomm modems in SBL ramdump mode.
> 
> Signed-off-by: Jerry Meng <jerry.meng.lk@...ctel.com>
> ---
> v1 -> v2:
> 	- Fix errors checked by checkpatch.pl, mainly change indentation from space to tab
> 	- change my email acount to fit git-send-email
> 
>   drivers/net/wwan/mhi_wwan_ctrl.c | 1 +
>   drivers/net/wwan/wwan_core.c     | 4 ++++
>   include/linux/wwan.h             | 2 ++
>   3 files changed, 7 insertions(+)
> 
> diff --git a/drivers/net/wwan/mhi_wwan_ctrl.c b/drivers/net/wwan/mhi_wwan_ctrl.c
> index e9f979d2d..082090ae5 100644
> --- a/drivers/net/wwan/mhi_wwan_ctrl.c
> +++ b/drivers/net/wwan/mhi_wwan_ctrl.c
> @@ -263,6 +263,7 @@ static const struct mhi_device_id mhi_wwan_ctrl_match_table[] = {
>   	{ .chan = "QMI", .driver_data = WWAN_PORT_QMI },
>   	{ .chan = "DIAG", .driver_data = WWAN_PORT_QCDM },
>   	{ .chan = "FIREHOSE", .driver_data = WWAN_PORT_FIREHOSE },
> +	{ .chan = "SAHARA", .driver_data = WWAN_PORT_SAHARA},
                                                            ^
The space is still missing between WWAN_PORT_SAHARA and trailing '}'. 
Please follow the format of existing table entries.

>   	{},
>   };
>   MODULE_DEVICE_TABLE(mhi, mhi_wwan_ctrl_match_table);
> diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
> index a51e27559..5eb0d6de3 100644
> --- a/drivers/net/wwan/wwan_core.c
> +++ b/drivers/net/wwan/wwan_core.c
> @@ -342,6 +342,10 @@ static const struct {
>   		.name = "MIPC",
>   		.devsuf = "mipc",
>   	},
> +	[WWAN_PORT_SAHARA] = {
> +		.name = "SAHARA",
> +		.devsuf = "sahara",
> +	},
>   };
>   
>   static ssize_t type_show(struct device *dev, struct device_attribute *attr,
> diff --git a/include/linux/wwan.h b/include/linux/wwan.h
> index 79c781875..b0ea276f2 100644
> --- a/include/linux/wwan.h
> +++ b/include/linux/wwan.h
> @@ -19,6 +19,7 @@
>   * @WWAN_PORT_FASTBOOT: Fastboot protocol control
>   * @WWAN_PORT_ADB: ADB protocol control
>   * @WWAN_PORT_MIPC: MTK MIPC diagnostic interface
> + * @WWAN_PORT_SAHARA: Sahara protocol-based interface for downloading ramdump from Qualcomm modems
>   *
>   * @WWAN_PORT_MAX: Highest supported port types
>   * @WWAN_PORT_UNKNOWN: Special value to indicate an unknown port type
> @@ -34,6 +35,7 @@ enum wwan_port_type {
>   	WWAN_PORT_FASTBOOT,
>   	WWAN_PORT_ADB,
>   	WWAN_PORT_MIPC,
> +	WWAN_PORT_SAHARA,
>   
>   	/* Add new port types above this line */
>