linux-kernel - Re: [PATCH v4 00/11] dmaengine: qcom: bam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad5dcd6c-1dbf-d682-024a-d4093611388f@quicinc.com>
Date: Wed, 20 Nov 2024 12:45:14 +0530
From: Md Sadre Alam <quic_mdalam@...cinc.com>
To: <thara.gopinath@...il.com>, <herbert@...dor.apana.org.au>,
        <davem@...emloft.net>, <vkoul@...nel.org>, <kees@...nel.org>,
        <robin.murphy@....com>, <fenghua.yu@...el.com>, <av2082000@...il.com>,
        <u.kleine-koenig@...gutronix.d>, <linux-crypto@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <dmaengine@...r.kernel.org>, <quic_varada@...cinc.com>,
        <quic_srichara@...cinc.com>
Subject: Re: [PATCH v4 00/11] dmaengine: qcom: bam_dma: add cmd descriptor
 support



On 9/9/2024 2:56 PM, Md Sadre Alam wrote:
> Requirements:
>    In QCE crypto driver we are accessing the crypto engine registers
>    directly via CPU read/write. Trust Zone could possibly to perform some
>    crypto operations simultaneously, a race condition will be created and
>    this could result in undefined behavior.
> 
>    To avoid this behavior we need to use BAM HW LOCK/UNLOCK feature on BAM
>    pipes, and this LOCK/UNLOCK will be set via sending a command descriptor,
>    where the HLOS/TZ QCE crypto driver prepares a command descriptor with a
>    dummy write operation on one of the QCE crypto engine register and pass
>    the LOCK/UNLOCK flag along with it.
> 
>    This feature tested with tcrypt.ko and "libkcapi" with all the AES
>    algorithm supported by QCE crypto engine. Tested on IPQ9574 and
>    qcm6490.LE chipset.

Hi,

Could you please provide feedback for this patch series.

Thanks
Alam.