linux-kernel - Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <410ebbd0-2304-4d9e-8d4a-5e63ab29ada8@kernel.org>
Date: Wed, 20 Nov 2024 08:38:15 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: keith zhao <keith.zhao@...rfivetech.com>, devicetree@...r.kernel.org,
 dri-devel@...ts.freedesktop.org
Cc: andrzej.hajda@...el.com, neil.armstrong@...aro.org, rfoss@...nel.org,
 Laurent.pinchart@...asonboard.com, jonas@...boo.se,
 jernej.skrabec@...il.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 hjc@...k-chips.com, heiko@...ech.de, andy.yan@...k-chips.com,
 william.qiu@...rfivetech.com, xingyu.wu@...rfivetech.com, kernel@...il.dk,
 paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu,
 p.zabel@...gutronix.de, changhuang.liang@...rfivetech.com,
 jack.zhu@...rfivetech.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.

On 20/11/2024 07:18, keith zhao wrote:
> +	/* Unmute hotplug interrupt */
> +	hdmi_modb(hdmi, HDMI_STATUS, m_MASK_INT_HOTPLUG, v_MASK_INT_HOTPLUG(1));
> +
> +	ret = devm_request_threaded_irq(hdmi->dev, irq, inno_hdmi_hardirq,
> +					inno_hdmi_irq, IRQF_SHARED,
> +					dev_name(hdmi->dev), hdmi);
> +	return ret;
> +}
> +EXPORT_SYMBOL_GPL(inno_hdmi_bind);
> +
> +MODULE_AUTHOR("Keith Zhao <keithzhao@...rfivetech.com>");
> +MODULE_DESCRIPTION("INNO HDMI transmitter driver");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:inno-hdmi");

You should not need MODULE_ALIAS() in normal cases. If you need it,
usually it means your device ID table is wrong (e.g. misses either
entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
for incomplete ID table.

Best regards,
Krzysztof