linux-kernel - Re: [PATCH v3 1/2] dt-bindings: power/supply: Add ltc4162-f/s and ltc4015

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bwn36yetahe7bjwsrcx4lljn6r7ta4d2r6pacq4ccmxbkkurpo@vkgjle4ckl6b>
Date: Wed, 20 Nov 2024 09:12:32 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kim Seer Paller <kimseer.paller@...log.com>
Cc: linux-pm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Sebastian Reichel <sre@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Mike Looijmans <mike.looijmans@...ic.nl>
Subject: Re: [PATCH v3 1/2] dt-bindings: power/supply: Add ltc4162-f/s and
 ltc4015

On Tue, Nov 19, 2024 at 11:23:03AM +0800, Kim Seer Paller wrote:
> Add LTC4162-F/S and LTC4015 to the supported devices of LTC4162-L.
> They share a common set of registers. The only differences lie in the
> resolution value of the scaling factor for battery voltage and battery
> current measurement, input voltage, and input current for different
> battery chemistries. The differences also include the calculation of
> setting and getting the actual voltage applied to the charge voltage,
> as well as getting the die temperature.
> 
> This add compatible entries for ltc4162-f/s and ltc4015 and include
> datasheets for new devices.
> 
> Signed-off-by: Kim Seer Paller <kimseer.paller@...log.com>
> ---
> V2 -> V3: Described differences in the programming model between variants/devices.
> V1 -> V2: Modified commit message describing differences between
>           variants/devices.
> 
>  .../devicetree/bindings/power/supply/ltc4162-l.yaml         | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> index 29d536541..9b546150d 100644
> --- a/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/ltc4162-l.yaml
> @@ -17,12 +17,18 @@ description: |
>    panels, etc., and a rechargeable Lithium-Ion/Polymer battery.
>  
>    Specifications about the charger can be found at:
> +    https://www.analog.com/en/products/ltc4162-l.html
> +    https://www.analog.com/en/products/ltc4162-f.html
>      https://www.analog.com/en/products/ltc4162-s.html
> +    https://www.analog.com/en/products/ltc4015.html
>  
>  properties:
>    compatible:
>      enum:
>        - lltc,ltc4162-l
> +      - lltc,ltc4162-f
> +      - lltc,ltc4162-s
> +      - lltc,ltc4015

Keep alphabetical order.

I assume these are not compatible.

Best regards,
Krzysztof