[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5kz6ghe56yiprlvhyduv7olcrajvejyvulcpjav6doiyvr6dcl@6qlt4nebp4gb>
Date: Wed, 20 Nov 2024 09:14:47 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Marcelo Schmitt <marcelo.schmitt@...log.com>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com, jic23@...nel.org,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
marcelo.schmitt1@...il.com, linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: iio: adc: adi,ad4000: Add PulSAR
On Tue, Nov 19, 2024 at 09:53:40AM -0300, Marcelo Schmitt wrote:
> Extend the AD4000 series device tree documentation to also describe
> PulSAR devices.
>
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@...log.com>
> ---
> No changes from v2 -> v3.
>
> .../bindings/iio/adc/adi,ad4000.yaml | 71 +++++++++++++++++++
> 1 file changed, 71 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml
> index e413a9d8d2a2..4dbb3d2876f9 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml
> @@ -19,6 +19,20 @@ description: |
> https://www.analog.com/media/en/technical-documentation/data-sheets/ad4020-4021-4022.pdf
> https://www.analog.com/media/en/technical-documentation/data-sheets/adaq4001.pdf
> https://www.analog.com/media/en/technical-documentation/data-sheets/adaq4003.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7685.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7686.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7687.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7688.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7690.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7691.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7693.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7942.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7946.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7980.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7982.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7983.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7984.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7988-1_7988-5.pdf
>
> $ref: /schemas/spi/spi-peripheral-props.yaml#
>
> @@ -63,6 +77,37 @@ properties:
>
> - const: adi,adaq4003
>
> + - const: adi,ad7946
All such cases are just one enum. That's the preferred syntax.
> + - items:
> + - enum:
> + - adi,ad7942
> + - const: adi,ad7946
> +
> + - const: adi,ad7983
> + - items:
> + - enum:
> + - adi,ad7980
> + - adi,ad7988-5
> + - adi,ad7686
> + - adi,ad7685
Keep alphabetical order.
> + - adi,ad7988-1
> + - const: adi,ad7983
> +
> + - const: adi,ad7688
> + - items:
> + - enum:
> + - adi,ad7693
> + - adi,ad7687
> + - const: adi,ad7688
> +
> + - const: adi,ad7984
> + - items:
> + - enum:
> + - adi,ad7982
> + - adi,ad7690
> + - adi,ad7691
> + - const: adi,ad7984
> +
> reg:
> maxItems: 1
>
> @@ -133,6 +178,32 @@ required:
> - ref-supply
>
> allOf:
> + # Single-channel PulSAR devices have SDI either tied to VIO, GND, or host CS.
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - adi,ad7685
Why do you need this? It's fallback is already here.
> + - adi,ad7686
> + - adi,ad7687
> + - adi,ad7688
> + - adi,ad7690
> + - adi,ad7691
> + - adi,ad7693
> + - adi,ad7942
> + - adi,ad7946
> + - adi,ad7980
> + - adi,ad7982
> + - adi,ad7983
> + - adi,ad7984
> + - adi,ad7988-1
> + - adi,ad7988-5
Best regards,
Krzysztof
Powered by blists - more mailing lists