[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <uzqdch4xiesvc3wq6fcpv7ulw3g7olvyxed7s5payhlddgubiq@apnlq7xgzrjo>
Date: Wed, 20 Nov 2024 09:57:14 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Heiko Stuebner <heiko@...ech.de>
Cc: srinivas.kandagatla@...aro.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, detlev.casanova@...labora.com, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-clk@...r.kernel.org, sebastian.reichel@...labora.com
Subject: Re: [PATCH 3/5] dt-bindings: nvmem: rockchip,otp: Add compatible for
RK3576
On Tue, Nov 19, 2024 at 02:29:14PM +0100, Heiko Stuebner wrote:
> Document the OTP memory found on Rockchip RK3576 SoC.
>
> The RK3576 uses the same set of clocks as the px30/rk3308
> but has one reset more, so adapt the binding to handle this
> variant as well.
>
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> ---
> .../bindings/nvmem/rockchip,otp.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
> index a44d44b32809..dae7543a0179 100644
> --- a/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
> @@ -14,6 +14,7 @@ properties:
> enum:
> - rockchip,px30-otp
> - rockchip,rk3308-otp
> + - rockchip,rk3576-otp
> - rockchip,rk3588-otp
>
> reg:
> @@ -68,6 +69,23 @@ allOf:
> items:
> - const: phy
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - rockchip,rk3576-otp
> + then:
> + properties:
> + clocks:
> + minItems: 3
That's redundant. 3 is there already. You wanted maxItems?
Missing constraint on clock-names (existing binding should be fixed as
well, separate patch).
> + resets:
> + minItems: 2
missing maxItems
> + reset-names:
> + items:
> + - const: otp
> + - const: apb
Best regards,
Krzysztof
Powered by blists - more mailing lists