linux-kernel - Re: [PATCH] arm64: dts: qcom: qcs9100: Update memory map for QCS9100 Ride and QCS9100 Ride Rev3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <rnrxb5e7xcgnjp4y4id5m5dyswii6xipry3bvtpit2f4c3iqfy@qghr42jz6oze>
Date: Wed, 20 Nov 2024 13:54:55 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Kuldeep Singh <quic_kuldsing@...cinc.com>
Cc: Pratyush Brahma <quic_pbrahma@...cinc.com>, 
	Bjorn Andersson <bjorn.andersson@...mple.com>, Konrad Dybcio <konrad.dybcio@...mple.com>, 
	Rob Herring <rob.herring@...mple.com>, Krzysztof Kozlowski <krzysztof.kozlowski@...mple.com>, 
	Conor Dooley <conor.dooley@...mple.com>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, quic_tengfan@...cinc.com, quic_shashim@...cinc.com
Subject: Re: [PATCH] arm64: dts: qcom: qcs9100: Update memory map for QCS9100
 Ride and QCS9100 Ride Rev3

On Wed, Nov 20, 2024 at 01:41:03AM +0530, Kuldeep Singh wrote:
> 
> 
> On 11/19/2024 2:55 PM, Pratyush Brahma wrote:
> > This patch series is based on Tengfei Fan's patches [1] which adds support
> > for QCS9100 Ride and QCS9100 Ride Rev3 boards.
> > 
> > Some new carveouts (viz. gunyah_md and a few pil dtb carveouts) have been
> > introduced and the size and base addresses have been updated for
> > a few of existing carveouts compared to SA8775P. Also, tz_ffi_mem carveout
> > and its corresponding scm reference has been removed as it is not required
> > for these boards. Incorporate these changes in the updated memory map
> > for QCS9100 Ride and QCS9100 Rev3 boards.
> > 
> > [1] https://lore.kernel.org/all/20240911-add_qcs9100_support-v2-4-e43a71ceb017@quicinc.com/
> > 
> > Signed-off-by: Pratyush Brahma <quic_pbrahma@...cinc.com>
> 
> The memory map for qcs9100-ride-r3 and qcs9100-ride is exactly same.
> A good churn you are first deleting(based on sa8775p) and then re-adding
> for qcs9100-ride*.
> 
> I think it's better to move common qcs9100-ride* to a common file ex:
> qcs9100-ride.dtsi and keep specifics further to .dts files?
> 
> This will ensure common entities are present at same place with no
> duplicates.

I'd second this proposal.

-- 
With best wishes
Dmitry