linux-kernel - Re: [PATCH] arm64: dts: qcom: qcs9100: Update memory map for QCS9100 Ride and QCS9100 Ride Rev3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e930d07-4b0b-422f-8435-b25ab14e585e@quicinc.com>
Date: Wed, 20 Nov 2024 12:04:04 +0530
From: Pratyush Brahma <quic_pbrahma@...cinc.com>
To: Kuldeep Singh <quic_kuldsing@...cinc.com>,
        Bjorn Andersson
	<bjorn.andersson@...mple.com>,
        Konrad Dybcio <konrad.dybcio@...mple.com>,
        "Rob Herring" <rob.herring@...mple.com>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski@...mple.com>,
        Conor Dooley <conor.dooley@...mple.com>
CC: <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_tengfan@...cinc.com>,
        <quic_shashim@...cinc.com>
Subject: Re: [PATCH] arm64: dts: qcom: qcs9100: Update memory map for QCS9100
 Ride and QCS9100 Ride Rev3


On 11/20/2024 1:41 AM, Kuldeep Singh wrote:
>
> On 11/19/2024 2:55 PM, Pratyush Brahma wrote:
>> This patch series is based on Tengfei Fan's patches [1] which adds support
>> for QCS9100 Ride and QCS9100 Ride Rev3 boards.
>>
>> Some new carveouts (viz. gunyah_md and a few pil dtb carveouts) have been
>> introduced and the size and base addresses have been updated for
>> a few of existing carveouts compared to SA8775P. Also, tz_ffi_mem carveout
>> and its corresponding scm reference has been removed as it is not required
>> for these boards. Incorporate these changes in the updated memory map
>> for QCS9100 Ride and QCS9100 Rev3 boards.
>>
>> [1] https://lore.kernel.org/all/20240911-add_qcs9100_support-v2-4-e43a71ceb017@quicinc.com/
>>
>> Signed-off-by: Pratyush Brahma <quic_pbrahma@...cinc.com>
> The memory map for qcs9100-ride-r3 and qcs9100-ride is exactly same.
> A good churn you are first deleting(based on sa8775p) and then re-adding
> for qcs9100-ride*.
>
> I think it's better to move common qcs9100-ride* to a common file ex:
> qcs9100-ride.dtsi and keep specifics further to .dts files?
>
> This will ensure common entities are present at same place with no
> duplicates.
>
> --
>
> Regards
> Kuldeep
It is true that the memory map for qcs9100-ride.dts and 
qcs9100-ride-r3.dts is exactly
the same. However, I am not sure if having a new common dtsi file would 
be the right approach
here since qcs9100* dts files inherit the sa8775p.dtsi file already.
I'll wait for Bjorn's comment here.

-- 
Thanks and Regards
Pratyush Brahma