[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK7LNAQDMJUYUF7BaN10bwctW7fuHmSMrrAjMmn4s7P2ys5P+Q@mail.gmail.com>
Date: Fri, 22 Nov 2024 07:28:33 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Rob Clark <robdclark@...il.com>
Cc: Petr Vorel <pvorel@...e.cz>, linux-arm-msm@...r.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, Andrew Morton <akpm@...ux-foundation.org>,
linux-kbuild@...r.kernel.org, dri-devel@...ts.freedesktop.org,
freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] init/Kconfig: add python3 availability config
On Thu, Nov 21, 2024 at 10:49 AM Rob Clark <robdclark@...il.com> wrote:
>
> On Wed, Nov 20, 2024 at 5:17 PM Petr Vorel <pvorel@...e.cz> wrote:
> >
> > > On Thu, Nov 21, 2024 at 5:41 AM Petr Vorel <pvorel@...e.cz> wrote:
> >
> > > > It will be used in the next commit for DRM_MSM.
> >
> > > > Suggested-by: Rob Clark <robdclark@...il.com>
> > > > Signed-off-by: Petr Vorel <pvorel@...e.cz>
> > > > ---
> > > > Changes v3->v4:
> > > > * Move definition to the end of the file
> >
> >
> > > I prefer to not check the tool.
> >
> > Ack.
> >
> > > Why don't you install python3?
> >
> > Everybody installs it when it's required, the question is how to inform about
> > the dependency.
> >
> > There build environments are minimal environments:
> > * chroot (e.g. cross compilation)
> > * container
> >
> > These are used by both developers and distros.
>
> I don't think py3 is an _onerous_ dependency, but it has come up as a
> surprise in minimal distro build environments at least once.. so I'd
> be a fan of surfacing this dependency in a predictable/understandable
> way (ie. I'm in favor of this patchset)
"once" is a keyword here.
"/bin/sh: python3: not found" provides sufficient information
about why the compilation failed, and you know what to do
to fix the problem.
This is good.
If you hide CONFIG_DRM_MSM silently
due to missing python3, you may scratch your head
"why drm/msm was not compiled?".
This is worse.
--
Best Regards
Masahiro Yamada
Powered by blists - more mailing lists