linux-kernel - Re: [PATCH net-next v2] net: wwan: Add WWAN sahara port type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33d70ece-15db-4c83-90a4-3daa2f4032fd@gmail.com>
Date: Fri, 22 Nov 2024 01:43:06 +0200
From: Sergey Ryazanov <ryazanov.s.a@...il.com>
To: Jeffrey Hugo <quic_jhugo@...cinc.com>
Cc: Jerry Meng <jerry.meng.lk@...ctel.com>, loic.poulain@...aro.org,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: wwan: Add WWAN sahara port type

On 22.11.2024 01:02, Jeffrey Hugo wrote:
> On 11/21/2024 3:53 PM, Sergey Ryazanov wrote:
>> On 20.11.2024 23:48, Jeffrey Hugo wrote:
>>> On 11/20/2024 1:36 PM, Sergey Ryazanov wrote:
>>>> +Manivannan
>>>>
>>>> Hello Jerry,
>>>>
>>>> this version looks a way better, still there is one minor thing to 
>>>> improve. See below.
>>>>
>>>> Manivannan, Loic, could you advice is it Ok to export that SAHARA 
>>>> port as is?
>>>
>>> I'm against this.
>>>
>>> There is an in-kernel Sahara implementation, which is going to be 
>>> used by QDU100.  If WWAN is going to own the "SAHARA" MHI channel 
>>> name, then no one else can use it which will conflict with QDU100.
>>>
>>> I expect the in-kernel implementation can be leveraged for this.
>>
>> Make sense. Can you share a link to this in-kernel implementation? 
>> I've searched through the code and found nothing similar. Is it merged 
>> or has it a different name?
> 
> drivers/accel/qaic/sahara.c

I was searching for SAHARA and for sahara in the log, however it was 
introduced as Sahara. Next time will use case insensitive search :) 
Thank you for the clue.

--
Sergey