linux-kernel - Re: [PATCH v5 3/8] virtio: hookup irq_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffe464b8-5991-49f0-9053-4f0a52af4fe7@flourine.local>
Date: Thu, 21 Nov 2024 10:44:32 +0100
From: Daniel Wagner <dwagner@...e.de>
To: John Garry <john.g.garry@...cle.com>
Cc: Daniel Wagner <wagi@...nel.org>, Jens Axboe <axboe@...nel.dk>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, "Michael S. Tsirkin" <mst@...hat.com>, 
	Jason Wang <jasowang@...hat.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, 
	Eugenio Pérez <eperezma@...hat.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, 
	Keith Busch <kbusch@...nel.org>, Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Hannes Reinecke <hare@...e.de>, Ming Lei <ming.lei@...hat.com>, 
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, 
	virtualization@...ts.linux.dev, linux-scsi@...r.kernel.org, megaraidlinux.pdl@...adcom.com, 
	mpi3mr-linuxdrv.pdl@...adcom.com, MPT-FusionLinux.pdl@...adcom.com, storagedev@...rochip.com, 
	linux-nvme@...ts.infradead.org
Subject: Re: [PATCH v5 3/8] virtio: hookup irq_get_affinity callback

On Thu, Nov 21, 2024 at 09:01:49AM +0000, John Garry wrote:
> > --- a/drivers/virtio/virtio.c
> > +++ b/drivers/virtio/virtio.c
> > @@ -377,6 +377,24 @@ static void virtio_dev_remove(struct device *_d)
> >   	of_node_put(dev->dev.of_node);
> >   }
> > +/**
> 
> nit: does this really need to be kerneldoc, as it is static?

No, it's not necessary, I didn't know what the rules for static
functions are. I'll update it accordingly.