linux-kernel - Re: [PATCH v5 4/8] blk-mq: introduce blk_mq_map_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <95035ac7-8707-4a69-8425-86a47841c15d@flourine.local>
Date: Mon, 2 Dec 2024 14:48:53 +0100
From: Daniel Wagner <dwagner@...e.de>
To: John Garry <john.g.garry@...cle.com>
Cc: Daniel Wagner <wagi@...nel.org>, Jens Axboe <axboe@...nel.dk>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, "Michael S. Tsirkin" <mst@...hat.com>, 
	Jason Wang <jasowang@...hat.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, 
	Eugenio Pérez <eperezma@...hat.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, 
	Keith Busch <kbusch@...nel.org>, Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Hannes Reinecke <hare@...e.de>, Ming Lei <ming.lei@...hat.com>, 
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, 
	virtualization@...ts.linux.dev, linux-scsi@...r.kernel.org, megaraidlinux.pdl@...adcom.com, 
	mpi3mr-linuxdrv.pdl@...adcom.com, MPT-FusionLinux.pdl@...adcom.com, storagedev@...rochip.com, 
	linux-nvme@...ts.infradead.org
Subject: Re: [PATCH v5 4/8] blk-mq: introduce blk_mq_map_hw_queues

On Thu, Nov 21, 2024 at 09:08:02AM +0000, John Garry wrote:
> > +/**
> > + * blk_mq_map_hw_queues - Create CPU to hardware queue mapping
> > + * @qmap:	CPU to hardware queue map.
> > + * @dev:	The device to map queues.
> > + * @offset:	Queue offset to use for the device.
> 
> supernit: maybe no '.'

np. I've followed the style of the function right above. Dropped them.

> is there still a blank line at the bottom of the file?

It ends with (vim):

	}
	EXPORT_SYMBOL_GPL(blk_mq_map_hw_queues);
	~

I hope that is what it supposed to be.

Daniel