linux-kernel - Re: [PATCH v3 1/2] dt-bindings: usb: Add microchip USB5807 HUB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3c88450-fbe3-42b9-a2ed-901ffdadfe1c@topic.nl>
Date: Thu, 21 Nov 2024 10:54:00 +0100
From: Mike Looijmans <mike.looijmans@...ic.nl>
To: AKASH KUMAR <quic_akakum@...cinc.com>, Rob Herring <robh@...nel.org>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 devicetree@...r.kernel.org, linux-usb@...r.kernel.org,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: usb: Add microchip USB5807 HUB

Hi Akash,

I was planning to, but the project was terminated so there was no budget to 
finalize it. You're free to take over and make the required changes.

M.

On 21-11-2024 09:34, AKASH KUMAR wrote:
> Hi @Mike
>
> Do you have plans to mainline this change?
>
> We are using microchip hub in one of our project and we need this driver,
> we have taken your change and able to enable usb hub.
> Please check if you can push updated patchset addressing the comments from Rob.
>
> On 5/22/2023 1:58 PM, Rob Herring wrote:
>> On Mon, 22 May 2023 09:45:09 +0200, Mike Looijmans wrote:
>>> The USB5807 is a 7-port USB 3.1 hub that can be configured by I2C.
>>> This driver resets the chip, optionally allows D+/D- lines to be
>>> swapped in the devicetree config, and then sends an ATTACH command to
>>> put the device in operational mode.
>>>
>>> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>
>>>
>>> ---
>>>
>>> Changes in v3:
>>> Add minItems
>>>
>>> Changes in v2:
>>> Rename to microchip,usb5807.yaml
>>> Remove reset-gpios description
>>> Add maxItems
>>> Add vddXX-supply properties
>>>
>>>   .../bindings/usb/microchip,usb5807.yaml       | 58 +++++++++++++++++++
>>>   1 file changed, 58 insertions(+)
>>>   create mode 100644 
>>> Documentation/devicetree/bindings/usb/microchip,usb5807.yaml
>>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb251xb.example.dtb: 
>> usb-hub@2d: swap-dx-lanes: size is 32, expected 8
>>     From schema: 
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb251xb.yaml
>>
>> doc reference errors (make refcheckdocs):
>>
>> See 
>> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230522074510.16367-1-mike.looijmans@topic.nl
>>
>> The base for the series is generally the latest rc1. A different dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit after running the above command yourself. Note
>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>> your schema. However, it must be unset to test all examples with your schema.
> Thanks,
> Akash