linux-kernel - Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ccf63c6c-c9a0-4a15-9edf-8d2bfdc78538@kernel.org>
Date: Thu, 21 Nov 2024 11:03:22 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Keith Zhao <keith.zhao@...rfivetech.com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Cc: "andrzej.hajda@...el.com" <andrzej.hajda@...el.com>,
 "neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
 "rfoss@...nel.org" <rfoss@...nel.org>,
 "Laurent.pinchart@...asonboard.com" <Laurent.pinchart@...asonboard.com>,
 "jonas@...boo.se" <jonas@...boo.se>,
 "jernej.skrabec@...il.com" <jernej.skrabec@...il.com>,
 "maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
 "mripard@...nel.org" <mripard@...nel.org>,
 "tzimmermann@...e.de" <tzimmermann@...e.de>,
 "airlied@...il.com" <airlied@...il.com>, "simona@...ll.ch"
 <simona@...ll.ch>, "robh@...nel.org" <robh@...nel.org>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "hjc@...k-chips.com" <hjc@...k-chips.com>, "heiko@...ech.de"
 <heiko@...ech.de>, "andy.yan@...k-chips.com" <andy.yan@...k-chips.com>,
 William Qiu <william.qiu@...rfivetech.com>,
 Xingyu Wu <xingyu.wu@...rfivetech.com>, "kernel@...il.dk" <kernel@...il.dk>,
 "paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
 "palmer@...belt.com" <palmer@...belt.com>,
 "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
 "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
 Changhuang Liang <changhuang.liang@...rfivetech.com>,
 Jack Zhu <jack.zhu@...rfivetech.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.

On 21/11/2024 03:15, Keith Zhao wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@...nel.org>
>> Sent: 2024年11月20日 15:38
>> To: Keith Zhao <keith.zhao@...rfivetech.com>; devicetree@...r.kernel.org;
>> dri-devel@...ts.freedesktop.org
>> Cc: andrzej.hajda@...el.com; neil.armstrong@...aro.org; rfoss@...nel.org;
>> Laurent.pinchart@...asonboard.com; jonas@...boo.se;
>> jernej.skrabec@...il.com; maarten.lankhorst@...ux.intel.com;
>> mripard@...nel.org; tzimmermann@...e.de; airlied@...il.com;
>> simona@...ll.ch; robh@...nel.org; krzk+dt@...nel.org; conor+dt@...nel.org;
>> hjc@...k-chips.com; heiko@...ech.de; andy.yan@...k-chips.com; William Qiu
>> <william.qiu@...rfivetech.com>; Xingyu Wu <xingyu.wu@...rfivetech.com>;
>> kernel@...il.dk; paul.walmsley@...ive.com; palmer@...belt.com;
>> aou@...s.berkeley.edu; p.zabel@...gutronix.de; Changhuang Liang
>> <changhuang.liang@...rfivetech.com>; Jack Zhu <jack.zhu@...rfivetech.com>;
>> linux-kernel@...r.kernel.org
>> Subject: Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.
>>
>> On 20/11/2024 07:18, keith zhao wrote:
>>> +	/* Unmute hotplug interrupt */
>>> +	hdmi_modb(hdmi, HDMI_STATUS, m_MASK_INT_HOTPLUG,
>>> +v_MASK_INT_HOTPLUG(1));
>>> +
>>> +	ret = devm_request_threaded_irq(hdmi->dev, irq, inno_hdmi_hardirq,
>>> +					inno_hdmi_irq, IRQF_SHARED,
>>> +					dev_name(hdmi->dev), hdmi);
>>> +	return ret;
>>> +}
>>> +EXPORT_SYMBOL_GPL(inno_hdmi_bind);
>>> +
>>> +MODULE_AUTHOR("Keith Zhao <keithzhao@...rfivetech.com>");
>>> +MODULE_DESCRIPTION("INNO HDMI transmitter driver");
>>> +MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:inno-hdmi");
>>
>> You should not need MODULE_ALIAS() in normal cases. If you need it, usually it
>> means your device ID table is wrong (e.g. misses either entries or
>> MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute for incomplete
>> ID table.
>>
> Thank you for your suggestion! 
> I will review the device ID table to ensure its completeness 
> and avoid using MODULE_ALIAS().

In this context neither MODULE_ALIAS nor ID table are suitable/needed.
If you need them, means your driver does not build in all setups :/
Best regards,
Krzysztof