linux-kernel - Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ujegy7cw4kka4j6rrjf7fsigk7p4hw4rkitmp4rzt33qnlhv5@c6exsgaou5x7>
Date: Thu, 21 Nov 2024 15:04:52 +0100
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Keith Zhao <keith.zhao@...rfivetech.com>
Cc: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, 
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, "andrzej.hajda@...el.com" <andrzej.hajda@...el.com>, 
	"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>, "rfoss@...nel.org" <rfoss@...nel.org>, 
	"Laurent.pinchart@...asonboard.com" <Laurent.pinchart@...asonboard.com>, "jernej.skrabec@...il.com" <jernej.skrabec@...il.com>, 
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>, "mripard@...nel.org" <mripard@...nel.org>, 
	"tzimmermann@...e.de" <tzimmermann@...e.de>, "airlied@...il.com" <airlied@...il.com>, 
	"simona@...ll.ch" <simona@...ll.ch>, "robh@...nel.org" <robh@...nel.org>, 
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>, 
	"hjc@...k-chips.com" <hjc@...k-chips.com>, "heiko@...ech.de" <heiko@...ech.de>, 
	"andy.yan@...k-chips.com" <andy.yan@...k-chips.com>, William Qiu <william.qiu@...rfivetech.com>, 
	Xingyu Wu <xingyu.wu@...rfivetech.com>, "kernel@...il.dk" <kernel@...il.dk>, 
	"paul.walmsley@...ive.com" <paul.walmsley@...ive.com>, "palmer@...belt.com" <palmer@...belt.com>, 
	"aou@...s.berkeley.edu" <aou@...s.berkeley.edu>, "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, 
	Changhuang Liang <changhuang.liang@...rfivetech.com>, Jack Zhu <jack.zhu@...rfivetech.com>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.

On Thu, Nov 21, 2024 at 02:06:20AM +0000, Keith Zhao wrote:
> 
> 
> > -----Original Message-----
> > From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> > Sent: 2024年11月20日 22:56
> > To: Keith Zhao <keith.zhao@...rfivetech.com>
> > Cc: devicetree@...r.kernel.org; dri-devel@...ts.freedesktop.org;
> > andrzej.hajda@...el.com; neil.armstrong@...aro.org; rfoss@...nel.org;
> > Laurent.pinchart@...asonboard.com; jernej.skrabec@...il.com;
> > maarten.lankhorst@...ux.intel.com; mripard@...nel.org;
> > tzimmermann@...e.de; airlied@...il.com; simona@...ll.ch;
> > robh@...nel.org; krzk+dt@...nel.org; conor+dt@...nel.org;
> > hjc@...k-chips.com; heiko@...ech.de; andy.yan@...k-chips.com; William Qiu
> > <william.qiu@...rfivetech.com>; Xingyu Wu <xingyu.wu@...rfivetech.com>;
> > kernel@...il.dk; paul.walmsley@...ive.com; palmer@...belt.com;
> > aou@...s.berkeley.edu; p.zabel@...gutronix.de; Changhuang Liang
> > <changhuang.liang@...rfivetech.com>; Jack Zhu <jack.zhu@...rfivetech.com>;
> > linux-kernel@...r.kernel.org
> > Subject: Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.
> > 
> > Hello,
> > 
> > On Wed, Nov 20, 2024 at 02:18:42PM +0800, keith zhao wrote:
> > > +struct platform_driver inno_hdmi_driver = {
> > > +	.probe  = inno_hdmi_rockchip_probe,
> > > +	.remove_new = inno_hdmi_rockchip_remove,
> > 
> > Please use .remove instead of .remove_new.
> > 
> Thank you for the clarification regarding .remove_new. 
> I understand that it's a relic and that new drivers should implement .remove().
> 
> I have a question. One of the changes in this patch is to rename some function interfaces. 
> The original code is like this. 
> 
> struct platform_driver inno_hdmi_driver = {
> 	.probe  = inno_hdmi_probe,
> 	.remove_new = inno_hdmi_remove,
> 	.driver = {
> 		.name = "innohdmi-rockchip",
> 		.of_match_table = inno_hdmi_dt_ids,
> 	},
> };
> 
> Rename inno_hdmi_probe and inno_hdmi_remove
> struct platform_driver inno_hdmi_driver = {
> 	.probe  = inno_hdmi_rockchip_probe,
> 	.remove_new = inno_hdmi_rockchip_remove,
> 	.driver = {
> 		.name = "innohdmi-rockchip",
> 		.of_match_table = inno_hdmi_dt_ids,
> 	},
> };
> Based on the principle of maintaining consistency, 
> does it(remove_new) need to be changed?

If this isn't new code but moving from somewhere, don't change
.remove_new into .remove in the same patch. If you want, fix that in a
separate patch then.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)