linux-kernel - Re: [PATCH v2 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1dde768-aeb8-4777-b4f9-d3c52b046fbd@kernel.org>
Date: Thu, 21 Nov 2024 11:19:36 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Xin Liu <quic_liuxin@...cinc.com>, Bjorn Andersson
 <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@...cinc.com, quic_jiegan@...cinc.com,
 quic_aiquny@...cinc.com, quic_tingweiz@...cinc.com
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node

On 21/11/2024 10:44, Xin Liu wrote:
> 
> 
> 在 2024/11/21 0:59, Krzysztof Kozlowski 写道:
>> On 19/11/2024 11:23, Xin Liu wrote:
>>> Add watchdog clock on the Qualcomm QCS8300 Ride platform.
>>>
>>> Signed-off-by: Xin Liu <quic_liuxin@...cinc.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> index 7eed19a694c3..3024338bcfbc 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> @@ -265,3 +265,7 @@ &ufs_mem_phy {
>>>   	vdda-pll-supply = <&vreg_l5a>;
>>>   	status = "okay";
>>>   };
>>> +
>>> +&watchdog {
>>> +    clocks = <&sleep_clk>;
>>> +};
>>> \ No newline at end of file
>>
>> Look, your patches have errors...
>>
> This is the information when I apply my patch.
> ../linux-next$ git am ./wdt/test.patch
> Applying: arm64: dts: qcom: qcs8300-ride: Add watchdog node
> ../linux-next$
> 
> There are no error messages here.

So I made up that above error message? You sent patch with an error
message. I responded directly under it, so what can I say more?

You refuse to fix this, so I NAK this patch.
Best regards,
Krzysztof