linux-kernel - Re: [PATCH v2 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b16bb82c-a14a-4bc1-997b-97e709d3a462@quicinc.com>
Date: Thu, 21 Nov 2024 19:58:28 +0800
From: Xin Liu <quic_liuxin@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel@...cinc.com>,
        <quic_jiegan@...cinc.com>, <quic_aiquny@...cinc.com>,
        <quic_tingweiz@...cinc.com>
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: qcs8300-ride: Add watchdog node



在 2024/11/21 18:19, Krzysztof Kozlowski 写道:
> On 21/11/2024 10:44, Xin Liu wrote:
>>
>>
>> 在 2024/11/21 0:59, Krzysztof Kozlowski 写道:
>>> On 19/11/2024 11:23, Xin Liu wrote:
>>>> Add watchdog clock on the Qualcomm QCS8300 Ride platform.
>>>>
>>>> Signed-off-by: Xin Liu <quic_liuxin@...cinc.com>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++
>>>>    1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>>> index 7eed19a694c3..3024338bcfbc 100644
>>>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>>> @@ -265,3 +265,7 @@ &ufs_mem_phy {
>>>>    	vdda-pll-supply = <&vreg_l5a>;
>>>>    	status = "okay";
>>>>    };
>>>> +
>>>> +&watchdog {
>>>> +    clocks = <&sleep_clk>;
>>>> +};
>>>> \ No newline at end of file
>>>
>>> Look, your patches have errors...
>>>
>> This is the information when I apply my patch.
>> ../linux-next$ git am ./wdt/test.patch
>> Applying: arm64: dts: qcom: qcs8300-ride: Add watchdog node
>> ../linux-next$
>>
>> There are no error messages here.
> 
> So I made up that above error message? You sent patch with an error
> message. I responded directly under it, so what can I say more?
> 
> You refuse to fix this, so I NAK this patch.
Sorry, that's not what I meant. I realize my mistake and I will fix this 
issue in the next version. Thank you for your comments.
> Best regards,
> Krzysztof