linux-kernel - Re: [PATCH 1/3] platform/chrome: cros_ec_charge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e8bf721-f930-4365-be48-a8c5964c1457@kernel.org>
Date: Thu, 21 Nov 2024 15:00:13 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Thomas Weißschuh <thomas@...ch.de>,
 "Sung-Chi, Li" <lschyi@...omium.org>
Cc: Benson Leung <bleung@...omium.org>, Tzung-Bi Shih <tzungbi@...nel.org>,
 Guenter Roeck <groeck@...omium.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Lee Jones <lee@...nel.org>,
 linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev,
 devicetree@...r.kernel.org
Subject: Re: [PATCH 1/3] platform/chrome: cros_ec_charge_state: add new driver
 to control charge

On 21/11/2024 14:47, Thomas Weißschuh wrote:
> 
>> +
>> +	return 0;
>> +}
>> +
>> +static const struct platform_device_id cros_ec_charge_state_id[] = {
>> +	{ DRV_NAME,  0 },
>> +	{}
>> +};
> 
> Reference this in the platform_driver below.

And missing module device table... This wasn't ever tested as module.

Best regards,
Krzysztof