linux-kernel - Re: [PATCH 1/3] platform/chrome: cros_ec_charge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7fc1bbbc-3cba-45bd-a5b6-0029cb5bb8fd@t-8ch.de>
Date: Thu, 21 Nov 2024 15:11:30 +0100
From: Thomas Weißschuh <thomas@...ch.de>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: "Sung-Chi, Li" <lschyi@...omium.org>, 
	Benson Leung <bleung@...omium.org>, Tzung-Bi Shih <tzungbi@...nel.org>, 
	Guenter Roeck <groeck@...omium.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Lee Jones <lee@...nel.org>, 
	linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/3] platform/chrome: cros_ec_charge_state: add new
 driver to control charge

On 2024-11-21 15:00:13+0100, Krzysztof Kozlowski wrote:
> On 21/11/2024 14:47, Thomas Weißschuh wrote:
> > 
> >> +
> >> +	return 0;
> >> +}
> >> +
> >> +static const struct platform_device_id cros_ec_charge_state_id[] = {
> >> +	{ DRV_NAME,  0 },
> >> +	{}
> >> +};
> > 
> > Reference this in the platform_driver below.
> 
> And missing module device table... This wasn't ever tested as module.

It has one in the general MODULE_*() macro soup at the end of the file.
But yes, it should be moved where it can be found, right after
cros_ec_charge_state_id.