linux-kernel - Re: [PATCH v2 1/4] vdpa/octeon_ep: enable support for multiple interrupts per device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d7c846c-31fa-4f63-984e-d46670c1dfed@stanley.mountain>
Date: Thu, 21 Nov 2024 17:02:13 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Shijith Thotton <sthotton@...vell.com>
Cc: virtualization@...ts.linux.dev, mst@...hat.com, jasowang@...hat.com,
	schalla@...vell.com, vattunuru@...vell.com, ndabilpuram@...vell.com,
	jerinj@...vell.com, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	Eugenio Pérez <eperezma@...hat.com>,
	Satha Rao <skoteshwar@...vell.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] vdpa/octeon_ep: enable support for multiple
 interrupts per device

On Thu, Nov 21, 2024 at 07:09:43PM +0530, Shijith Thotton wrote:
> Updated the driver to utilize all the MSI-X interrupt vectors supported
> by each OCTEON endpoint VF, instead of relying on a single vector.
> Enabling more interrupts allows packets from multiple rings to be
> distributed across multiple cores, improving parallelism and
> performance.
> 
> Signed-off-by: Shijith Thotton <sthotton@...vell.com>
> ---
> v1:
> - https://lore.kernel.org/virtualization/20241120070508.789508-1-sthotton@marvell.com
> 
> Changes in v2:
> - Handle reset getting called twice.
> - Use devm_kcalloc to allocate irq array.
> - IRQ is never zero. Adjusted code accordingly.
> 

Thanks.  That takes care of all the issues that I saw so I'm okay with this now,
but I'm not a domain expert.

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter