linux-kernel - Re: [PATCH] ASoC: qcom: apq8016_sbc: Fix second argument of apq8016_dai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <387c84aa-dab1-44ca-8d42-bc19abc79434@sirena.org.uk>
Date: Thu, 21 Nov 2024 14:03:03 +0000
From: Mark Brown <broonie@...nel.org>
To: Bert Karwatzki <spasswolf@....de>
Cc: Stephan Gerhold <stephan@...hold.net>, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH] ASoC: qcom: apq8016_sbc: Fix second argument of
 apq8016_dai_init()

On Mon, Nov 18, 2024 at 12:20:58AM +0100, Bert Karwatzki wrote:
> Since commit a78a42fb48b8 the second argument of apq8016_dai_init() has
> to be an lpass id returned by qdsp6_dai_get_lpass_id().

This breaks the build:

/build/stage/linux/sound/soc/qcom/apq8016_sbc.c: In function ‘apq8016_sbc_dai_in
it’:
/build/stage/linux/sound/soc/qcom/apq8016_sbc.c:153:38: error: implicit declarat
ion of function ‘qdsp6_dai_get_lpass_id’ [-Werror=implicit-function-declaration]
  153 |         return apq8016_dai_init(rtd, qdsp6_dai_get_lpass_id(cpu_dai));
      |                                      ^~~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/sound/soc/qcom/apq8016_sbc.c: At top level:
/build/stage/linux/sound/soc/qcom/apq8016_sbc.c:165:12: error: static declaratio
n of ‘qdsp6_dai_get_lpass_id’ follows non-static declaration
  165 | static int qdsp6_dai_get_lpass_id(struct snd_soc_dai *cpu_dai)
      |            ^~~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/sound/soc/qcom/apq8016_sbc.c:153:38: note: previous implicit 
declaration of ‘qdsp6_dai_get_lpass_id’ with type ‘int()’
  153 |         return apq8016_dai_init(rtd, qdsp6_dai_get_lpass_id(cpu_dai));
      |                                      ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)