linux-kernel - Re: [PATCH 1/8] dt-bindings: mailbox: mediatek: Add GCE header file for MT8196

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2e4f939719a786b6ea7cbb58b55240105c85fad2.camel@mediatek.com>
Date: Thu, 21 Nov 2024 15:47:50 +0000
From: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
To: "krzk@...nel.org" <krzk@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	Singo Chang (張興國) <Singo.Chang@...iatek.com>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "simona@...ll.ch"
	<simona@...ll.ch>, "mchehab@...nel.org" <mchehab@...nel.org>,
	Moudy Ho (何宗原) <Moudy.Ho@...iatek.com>,
	Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"robh@...nel.org" <robh@...nel.org>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>, "airlied@...il.com"
	<airlied@...il.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "jassisinghbrar@...il.com"
	<jassisinghbrar@...il.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH 1/8] dt-bindings: mailbox: mediatek: Add GCE header file
 for MT8196

On Thu, 2024-11-21 at 12:48 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 21/11/2024 11:51, Jason-JH Lin (林睿祥) wrote:
> > > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@...iatek.com>
> > > > ---
> > > >  .../dt-bindings/mailbox/mediatek,mt8196-gce.h | 1449
> > > > +++++++++++++++++
> > > >  1 file changed, 1449 insertions(+)
> > > >  create mode 100755 include/dt-
> > > > bindings/mailbox/mediatek,mt8196-
> > > > gce.h
> > > 
> > > Please run scripts/checkpatch.pl and fix reported warnings. Then
> > > please
> > > run 'scripts/checkpatch.pl --strict' and (probably) fix more
> > > warnings.
> > > Some warnings can be ignored, especially from --strict run, but
> > > the
> > > code
> > > here looks like it needs a fix. Feel free to get in touch if the
> > > warning
> > > is not clear.
> > > 
> > > This goes with the binding.
> > > 
> > 
> > I thought I have done that, but I found a whitespace warning at
> > #1328
> > now. I'll fix that at the next version.
> > Thanks for the reminder.
> 
> There are multiple errors, including executable permission. I don't
> believe you run checkpatch.

Oh, my bad. You're right.
I have checked the history and found I missed this patch...

~/linux$ ./scripts/checkpatch.pl --strict --ignore=GERRIT_CHANGE_ID --
show-types 000*
---------------------------------------------------------------
0001-mailbox-mtk-cmdq-Add-driver-data-to-support-for-MT81.patch
---------------------------------------------------------------
total: 0 errors, 0 warnings, 0 checks, 223 lines checked

0001-mailbox-mtk-cmdq-Add-driver-data-to-support-for-MT81.patch has no
obvious style problems and is ready for submission.
---------------------------------------------------------------
0002-soc-mediatek-mtk-cmdq-Add-unsupported-subsys-ID-prog.patch
---------------------------------------------------------------
total: 0 errors, 0 warnings, 0 checks, 261 lines checked

0002-soc-mediatek-mtk-cmdq-Add-unsupported-subsys-ID-prog.patch has no
obvious style problems and is ready for submission.
---------------------------------------------------------------
0003-soc-mediatek-mtk-cmdq-Add-mminfra_offset-compatibili.patch
---------------------------------------------------------------
total: 0 errors, 0 warnings, 0 checks, 97 lines checked

0003-soc-mediatek-mtk-cmdq-Add-mminfra_offset-compatibili.patch has no
obvious style problems and is ready for submission.
----------------------------------------------------------
0004-soc-mediatek-Add-pa_base-due-to-CMDQ-API-change.patch
----------------------------------------------------------
total: 0 errors, 0 warnings, 0 checks, 15 lines checked

0004-soc-mediatek-Add-pa_base-due-to-CMDQ-API-change.patch has no
obvious style problems and is ready for submission.
----------------------------------------------------------
0005-drm-mediatek-Add-pa_base-due-to-CMDQ-API-change.patch
----------------------------------------------------------
total: 0 errors, 0 warnings, 0 checks, 24 lines checked

0005-drm-mediatek-Add-pa_base-due-to-CMDQ-API-change.patch has no
obvious style problems and is ready for submission.
---------------------------------------------------------------
0006-media-mediatek-mdp3-Add-pa_base-due-to-CMDQ-API-chan.patch
---------------------------------------------------------------
total: 0 errors, 0 warnings, 0 checks, 32 lines checked

0006-media-mediatek-mdp3-Add-pa_base-due-to-CMDQ-API-chan.patch has no
obvious style problems and is ready for submission.

Due to some IT policy, I run checkpatch and sent these patches in 2
different servers.
I have added it back and run checkpatch. Thanks!

Regards,
Jason-JH.Lin

> 
> Best regards,
> Krzysztof